-
Notifications
You must be signed in to change notification settings - Fork 119
OCPBUGS-59570, OCPBUGS-59566: Move Network Policy manifests #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-59570, OCPBUGS-59566: Move Network Policy manifests #652
Conversation
@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-59566, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The manifests are in the wrong place currently. This repository has static manifests that get copied to the container image during build time, from a static location (the `/manifests` folder). Moving over the NetworkPolicy manifests to the right location so that they're actually applied on cluster. Also include neccessary annotations that were missing previously, without which the CVO won't apply the manifests: ``` annotations: include.release.openshift.io/self-managed-high-availability: "true" include.release.openshift.io/single-node-developer: "true" capability.openshift.io/name: "marketplace" ``` Signed-off-by: Anik Bhattacharjee <[email protected]>
@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-59566, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Created a cluster-bot cluster using the command
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
/jira refresh |
@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-59566, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:
Comment This pull request references Jira Issue OCPBUGS-59566, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@anik120: This pull request references Jira Issue OCPBUGS-59570, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: This pull request references Jira Issue OCPBUGS-59566, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🎉
/approve
it seems in the right place now
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-operator |
/test e2e-aws-ovn-serial |
/retest-required |
4 similar comments
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/test e2e-aws-ovn-serial |
@anik120: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test e2e-aws-ovn-serial |
1 similar comment
/test e2e-aws-ovn-serial |
07c4ea7
into
operator-framework:master
@anik120: Jira Issue OCPBUGS-59570: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59570 has been moved to the MODIFIED state. Jira Issue OCPBUGS-59566: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59566 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: marketplace-operator |
The manifests are in the wrong place currently. This repository has static manifests that get copied to the container image during build time, from a static location (the
/manifests
folder). Moving over the NetworkPolicy manifests to the right location so that they're actually applied on cluster.Also included neccessary annotations that were missing previously, without
which the CVO won't apply the manifests:
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs