Skip to content

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Aug 7, 2025

The manifests are in the wrong place currently. This repository has static manifests that get copied to the container image during build time, from a static location (the /manifests folder). Moving over the NetworkPolicy manifests to the right location so that they're actually applied on cluster.

Also included neccessary annotations that were missing previously, without
which the CVO won't apply the manifests:

annotations:
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
    capability.openshift.io/name: "marketplace"

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 7, 2025
@openshift-ci-robot
Copy link
Contributor

@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-59566, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The manifests are in the wrong place currently. This repository has static manifests that get copied to the container image during build time, from a static location (the /manifests folder). Moving over the NetworkPolicy manifests to the right location so that they're actually applied on cluster.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 7, 2025
The manifests are in the wrong place currently. This repository has
static manifests that get copied to the container image during build time,
from a static location (the `/manifests` folder). Moving over the
NetworkPolicy manifests to the right location so that they're actually
applied on cluster.

Also include neccessary annotations that were missing previously, without
which the CVO won't apply the manifests:

```
annotations:
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
    capability.openshift.io/name: "marketplace"
```
Signed-off-by: Anik Bhattacharjee <[email protected]>
@openshift-ci-robot
Copy link
Contributor

@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-59566, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

The manifests are in the wrong place currently. This repository has static manifests that get copied to the container image during build time, from a static location (the /manifests folder). Moving over the NetworkPolicy manifests to the right location so that they're actually applied on cluster.

Also included neccessary annotations that were missing previously, without
which the CVO won't apply the manifests:

annotations:
   include.release.openshift.io/self-managed-high-availability: "true"
   include.release.openshift.io/single-node-developer: "true"
   capability.openshift.io/name: "marketplace"

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anik120
Copy link
Contributor Author

anik120 commented Aug 7, 2025

Created a cluster-bot cluster using the command launch 4.20,operator-framework/operator-marketplace#652 aws:

$ oc get clusterversion 
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2025-08-07-193828-test-ci-ln-73pzsf2-latest   True        False         25m     Cluster version is 4.20.0-0-2025-08-07-193828-test-ci-ln-73pzsf2-latest

$ oc get networkpolicy -n openshift-marketplace 
NAME                                 POD-SELECTOR                                                   AGE
certified-operators-grpc-server      olm.catalogSource=certified-operators,olm.managed=true         46m
certified-operators-unpack-bundles   olm.managed in (true),operatorframework.io/bundle-unpack-ref   46m
community-operators-grpc-server      olm.catalogSource=community-operators,olm.managed=true         46m
community-operators-unpack-bundles   olm.managed in (true),operatorframework.io/bundle-unpack-ref   46m
default-deny-all                     <none>                                                         45m
marketplace-operator                 name=marketplace-operator                                      45m
redhat-marketplace-grpc-server       olm.catalogSource=redhat-marketplace,olm.managed=true          46m
redhat-marketplace-unpack-bundles    olm.managed in (true),operatorframework.io/bundle-unpack-ref   46m
redhat-operators-grpc-server         olm.catalogSource=redhat-operators,olm.managed=true            46m
redhat-operators-unpack-bundles      olm.managed in (true),operatorframework.io/bundle-unpack-ref   46m
unpack-bundles                       olm.managed in (true),operatorframework.io/bundle-unpack-ref   45m

@anik120
Copy link
Contributor Author

anik120 commented Aug 8, 2025

/retest

3 similar comments
@anik120
Copy link
Contributor Author

anik120 commented Aug 8, 2025

/retest

@anik120
Copy link
Contributor Author

anik120 commented Aug 8, 2025

/retest

@anik120
Copy link
Contributor Author

anik120 commented Aug 11, 2025

/retest

@anik120
Copy link
Contributor Author

anik120 commented Aug 11, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-59566, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anik120
Copy link
Contributor Author

anik120 commented Aug 11, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@anik120: This pull request references Jira Issue OCPBUGS-59570, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references Jira Issue OCPBUGS-59566, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from kuiwang02 August 11, 2025 14:47
@anik120
Copy link
Contributor Author

anik120 commented Aug 11, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 11, 2025
@openshift-ci-robot
Copy link
Contributor

@anik120: This pull request references Jira Issue OCPBUGS-59570, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

This pull request references Jira Issue OCPBUGS-59566, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉

/approve

it seems in the right place now

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@camilamacedo86
Copy link
Contributor

/test e2e-gcp-operator

@camilamacedo86
Copy link
Contributor

/test e2e-aws-ovn-serial

@camilamacedo86
Copy link
Contributor

/retest-required

4 similar comments
@anik120
Copy link
Contributor Author

anik120 commented Aug 12, 2025

/retest-required

@camilamacedo86
Copy link
Contributor

/retest-required

@anik120
Copy link
Contributor Author

anik120 commented Aug 12, 2025

/retest-required

@anik120
Copy link
Contributor Author

anik120 commented Aug 12, 2025

/retest-required

@anik120
Copy link
Contributor Author

anik120 commented Aug 13, 2025

/test e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@anik120: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 4814559 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anik120
Copy link
Contributor Author

anik120 commented Aug 13, 2025

/test e2e-aws-ovn-serial

1 similar comment
@camilamacedo86
Copy link
Contributor

/test e2e-aws-ovn-serial

@openshift-merge-bot openshift-merge-bot bot merged commit 07c4ea7 into operator-framework:master Aug 13, 2025
10 of 11 checks passed
@openshift-ci-robot
Copy link
Contributor

@anik120: Jira Issue OCPBUGS-59570: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59570 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-59566: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59566 has been moved to the MODIFIED state.

In response to this:

The manifests are in the wrong place currently. This repository has static manifests that get copied to the container image during build time, from a static location (the /manifests folder). Moving over the NetworkPolicy manifests to the right location so that they're actually applied on cluster.

Also included neccessary annotations that were missing previously, without
which the CVO won't apply the manifests:

annotations:
   include.release.openshift.io/self-managed-high-availability: "true"
   include.release.openshift.io/single-node-developer: "true"
   capability.openshift.io/name: "marketplace"

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: marketplace-operator
This PR has been included in build marketplace-operator-container-v4.20.0-202508140144.p0.g07c4ea7.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants