Merge pull request #256 from exdx/feat/add-bundle-objects

feat: generate a bundle with configmap and secret objects

Author: openshift-merge-robot

pkg/lib/bundle/supported_resources.go

@@ -6,6 +6,7 @@ const (
 	SecretKind             = "Secret"
 	ClusterRoleKind        = "ClusterRole"
 	ClusterRoleBindingKind = "ClusterRoleBinding"
+	ConfigMapKind          = "ConfigMap"
 	ServiceAccountKind     = "ServiceAccount"
 	ServiceKind            = "Service"
 	RoleKind               = "Role"
@@ -14,28 +15,28 @@ const (
 	ServiceMonitorKind     = "ServiceMonitor"
 )
 
-var supportedResources map[string]bool
+// Namespaced indicates whether the resource is namespace scoped (true) or cluster-scoped (false).
+type Namespaced bool
 
-// Add a list of supported resources to the map
 // Key: Kind name
-// Value: If namaspaced kind, true. Otherwise, false
-func init() {
-	supportedResources = make(map[string]bool, 11)
-
-	supportedResources[CSVKind] = true
-	supportedResources[CRDKind] = false
-	supportedResources[ClusterRoleKind] = false
-	supportedResources[ClusterRoleBindingKind] = false
-	supportedResources[ServiceKind] = true
-	supportedResources[ServiceAccountKind] = true
-	supportedResources[RoleKind] = true
-	supportedResources[RoleBindingKind] = true
-	supportedResources[PrometheusRuleKind] = true
-	supportedResources[ServiceMonitorKind] = true
+// Value: If namespaced kind, true. Otherwise, false
+var supportedResources = map[string]Namespaced{
+	CSVKind:                true,
+	CRDKind:                false,
+	ClusterRoleKind:        false,
+	ClusterRoleBindingKind: false,
+	ServiceKind:            true,
+	ServiceAccountKind:     true,
+	RoleKind:               true,
+	RoleBindingKind:        true,
+	PrometheusRuleKind:     true,
+	ServiceMonitorKind:     true,
+	SecretKind:             true,
+	ConfigMapKind:          true,
 }
 
 // IsSupported checks if the object kind is OLM-supported and if it is namespaced
-func IsSupported(kind string) (bool, bool) {
+func IsSupported(kind string) (bool, Namespaced) {
 	namespaced, ok := supportedResources[kind]
 	return ok, namespaced
 }

pkg/lib/bundle/testdata/validate/valid_bundle/manifests/etcdconfigmap.yaml

@@ -0,0 +1,8 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: "my-config-map"
+data:
+  allowed: '"true"'
+  enemies: aliens
+  lives: "3"

pkg/lib/bundle/testdata/validate/valid_bundle/manifests/etcdsecret.yaml

@@ -0,0 +1,8 @@
+apiVersion: v1
+kind: Secret
+metadata:
+  name: mysecret
+type: Opaque
+data:
+  username: YWRtaW4=
+  password: MWYyZDFlMmU2N2Rm