Add goimports as a managed tool via bingo#1523
Add goimports as a managed tool via bingo#1523bentito wants to merge 1 commit intooperator-framework:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bentito The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I'll have to do a more thorough review later. Initial thoughts:
I know this one looked like a quick-touch, but it seems more like an iceberg. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1523 +/- ##
=======================================
Coverage 46.80% 46.80%
=======================================
Files 135 135
Lines 15760 15760
=======================================
Hits 7377 7377
Misses 7342 7342
Partials 1041 1041 ☔ View full report in Codecov by Sentry. |
|
well we can close this one if we've got plans to make things better, later. |
|
Yeah, let's close this one in favor of #1524. It's a PITA (over 300 linter findings!) but it would un-do this PR entirely. |
|
closing |
Description of the change:
Add goimports as a managed tool via bingo
Motivation for the change:
Other needed dev tools are installed via bingo, goimports should be too.
Reviewer Checklist
/docs