Skip to content

(fix) declCfg non-closed file descriptor #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

(fix) declCfg non-closed file descriptor #1625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions alpha/declcfg/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,15 +183,20 @@ func parseMetaPaths(ctx context.Context, root fs.FS, pathChan <-chan string, wal
if !ok {
return nil
}
file, err := root.Open(path)
err := func() error { // using closure to ensure file is closed immediately after use
file, err := root.Open(path)
if err != nil {
return err
}
defer file.Close()

return WalkMetasReader(file, func(meta *Meta, err error) error {
return walkFn(path, meta, err)
})
}()
if err != nil {
return err
}
if err := WalkMetasReader(file, func(meta *Meta, err error) error {
return walkFn(path, meta, err)
}); err != nil {
return err
}
}
}
}
Expand Down
Loading