Skip to content

pkg/image: fixup containers/image registry test with a test-defined signature policy #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

pkg/image: fixup containers/image registry test with a test-defined signature policy #1654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions pkg/image/registry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ type cleanupFunc func()
type newRegistryFunc func(t *testing.T, serverCert *x509.Certificate) (image.Registry, cleanupFunc)

func caDirForCert(t *testing.T, serverCert *x509.Certificate) string {
caDir, err := os.MkdirTemp("", "opm-registry-test-ca-")
require.NoError(t, err)
caDir := t.TempDir()
caFile, err := os.Create(filepath.Join(caDir, "ca.crt"))
require.NoError(t, err)

Expand All @@ -51,6 +50,29 @@ func caDirForCert(t *testing.T, serverCert *x509.Certificate) string {
return caDir
}

const insecureSignaturePolicy = `{
"default": [
{
"type": "insecureAcceptAnything"
}
],
"transports":
{
"docker-daemon":
{
"": [{"type":"insecureAcceptAnything"}]
}
}
}`

func createSignaturePolicyFile(t *testing.T) string {
policyDir := t.TempDir()
policyFilePath := filepath.Join(policyDir, "policy.json")
err := os.WriteFile(policyFilePath, []byte(insecureSignaturePolicy), 0600)
require.NoError(t, err)
return policyFilePath
}

func poolForCert(serverCert *x509.Certificate) *x509.CertPool {
rootCAs := x509.NewCertPool()
rootCAs.AddCert(serverCert)
Expand All @@ -61,10 +83,12 @@ func TestRegistries(t *testing.T) {
registries := map[string]newRegistryFunc{
"containersimage": func(t *testing.T, serverCert *x509.Certificate) (image.Registry, cleanupFunc) {
caDir := caDirForCert(t, serverCert)
policyFile := createSignaturePolicyFile(t)
sourceCtx := &types.SystemContext{
OCICertPath: caDir,
DockerCertPath: caDir,
DockerPerHostCertDirPath: caDir,
SignaturePolicyPath: policyFile,
}
r, err := containersimageregistry.New(sourceCtx, containersimageregistry.WithTemporaryImageCache())
require.NoError(t, err)
Expand Down