-
Notifications
You must be signed in to change notification settings - Fork 260
set an exception for migrate file permissions #1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set an exception for migrate file permissions #1798
Conversation
Signed-off-by: grokspawn <[email protected]>
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1798 +/- ##
=======================================
Coverage 55.27% 55.27%
=======================================
Files 136 136
Lines 15976 15976
=======================================
Hits 8830 8830
Misses 5991 5991
Partials 1155 1155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold remodel description to capture more context |
47dee8d
into
operator-framework:master
Description of the change:
Reverts #1524 changes to alpha/declcfg/write.go associated with FBC migration support.
Motivation for the change:
Though this represents a legitimate ratcheting of security concerns, and we'd like to in general adhere to the security best practices of gosec linter, in this case we intend to rely on appropriate umask configuration of end users.
Not only were users of the binary impacted, but indirect clients who vendored the packages.
Reviewer Checklist
/docs