Skip to content

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Sep 11, 2025

Description of the change:
Reverts #1524 changes to alpha/declcfg/write.go associated with FBC migration support.

Motivation for the change:
Though this represents a legitimate ratcheting of security concerns, and we'd like to in general adhere to the security best practices of gosec linter, in this case we intend to rely on appropriate umask configuration of end users.
Not only were users of the binary impacted, but indirect clients who vendored the packages.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.27%. Comparing base (0ec1210) to head (ae28a6b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
alpha/declcfg/write.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1798   +/-   ##
=======================================
  Coverage   55.27%   55.27%           
=======================================
  Files         136      136           
  Lines       15976    15976           
=======================================
  Hits         8830     8830           
  Misses       5991     5991           
  Partials     1155     1155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grokspawn grokspawn marked this pull request as ready for review September 11, 2025 16:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@grokspawn
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@grokspawn
Copy link
Contributor Author

/hold remodel description to capture more context

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 47dee8d into operator-framework:master Sep 11, 2025
12 of 13 checks passed
@grokspawn grokspawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@grokspawn grokspawn deleted the migrate-permissions branch September 11, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants