Refactor build configs and CKEditor types for TypeScript migration#109
Open
Refactor build configs and CKEditor types for TypeScript migration#109
Conversation
Add typed interfaces to op-ckeditor exports so downstream OpenProject code can replace its local CKEditor type shim. Configure ESLint to parse TypeScript syntax and keep lint, tests, typecheck, and build passing.
Introduce src/ckeditor-types.ts and export it via the package subpath '@openproject/commonmark-ckeditor-build/types'. Keep existing type exports from the main entrypoint and update README paths and type usage docs for downstream consumers.
Add a build-time copy step for generated declaration files. During build, copy types into OPENPROJECT_CORE frontend vendor ckeditor paths so downstream can import via core-vendor aliases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing