Merged
Conversation
Escaping of authorize_options happens by the main gem already, so we don't have to do that manually beforehand. The previous implementation led to double escaping, e.g. %22 became %2522. This error was also reflected in all test expectations.
NobodysNightmare
force-pushed
the
double-escaped-claims
branch
from
c514126 to
8e9e299
Compare
shiroginne
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escaping of authorize_options happens by the main gem already, so we don't have to do that manually beforehand. The previous implementation led to double escaping, e.g. %22 became %2522.
This error was also reflected in all test expectations.
Ticket
https://community.openproject.org/wp/69079