Skip to content

Conversation

@myabc
Copy link
Contributor

@myabc myabc commented Oct 2, 2025

See related downstream PR: opf/openproject#20367

See TypeCellOS/BlockNote#2033

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bumps BlockNote packages to 0.40 and adds Mantine dev dependencies for local development.

  • Upgrade @blocknote/mantine to ^0.40.0 and peer @blocknote/core/@blocknote/react to ^0.40
  • Add Mantine dev dependencies
  • Minor reordering in devDependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@judithroth
Copy link
Contributor

Thanks a lot for tackling this @myabc !
I have a hard time testing this at the moment, so I am not sure I can approve, although what you did looks good.
I tried testing with the react app that is part of this project but there I can't search for work packages because of CORS issues. Then I tried packaging this to a zip file for usage in Open Project, but npm run build:lib is broken at the moment:

 >npm run build:lib

> [email protected] build:lib
> vite build && tsc -b tsconfig.lib.json

vite v7.1.3 building for production...
✓ 31 modules transformed.
dist/op-blocknote-extensions.es.js  66.79 kB │ gzip: 22.25 kB
✓ built in 322ms
lib/helpers.ts:13:29 - error TS2349: This expression is not callable.
  Type '{ config: { readonly type: "openProjectWorkPackage"; readonly propSchema: { readonly wpid: { readonly default: ""; readonly type: "string"; }; readonly subject: { readonly default: ""; readonly type: "string"; }; readonly status: { ...; }; readonly assignee: { ...; }; readonly type: { ...; }; readonly href: { ...; }...' has no call signatures.

13   "openProjectWorkPackage": openProjectWorkPackageBlockSpec(),
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error.

I believe this is not your fault. This probably broke with the updates that were necessary for blocknote 0.39. And it is a sign that we need more tests here so that things like this do not get overseen.
Since I work only part time at the moment and try to get something else on the way, I think its best to wait for Bruno coming back from vacation next week.
Is that okay for you or do you think this should be tackled more urgently?

@myabc
Copy link
Contributor Author

myabc commented Oct 6, 2025

Is that okay for you or do you think this should be tackled more urgently?

It's not urgent. However if you want to tackle it together, we could pair on Wednesday. I'll ping you.

Copy link
Contributor

@judithroth judithroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, whatever I did on Monday evening, I think the problem was me, not the code 😄 I was able to package 0.0.7 and test it locally with your other branch that updates blocknote in OpenProject and it nearly works 🥳
When collaboration is enabled, there's still one issue after saving and re-opening the document, instead of the block with the workpackage, we get an empty editor and an error in the Console:
Screenshot from 2025-10-08 09-50-07

@brunopagno brunopagno self-assigned this Oct 15, 2025
@brunopagno
Copy link
Collaborator

I still need to learn a bit more about how the versions affect each other, but Mantine/BlockNote/BNReact need to be in sync to work properly (I guess it's reasonable).

I've tested locally the demo app and with OpenProject and found ways of making it work. Will create a counterpart PR on OpenProject once this one gets merged.

Copy link
Collaborator

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda approving my own changes here, but @myabc can double check to see if there's any alert~

@brunopagno brunopagno merged commit 8cd297c into main Oct 15, 2025
4 checks passed
@brunopagno brunopagno deleted the housekeeping/bump-blocknote-0.40.0 branch October 15, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants