-
Notifications
You must be signed in to change notification settings - Fork 1
deps: Bump BlockNote to 0.40.0, add Mantine dev deps #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Bumps BlockNote packages to 0.40 and adds Mantine dev dependencies for local development.
- Upgrade @blocknote/mantine to ^0.40.0 and peer @blocknote/core/@blocknote/react to ^0.40
- Add Mantine dev dependencies
- Minor reordering in devDependencies
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks a lot for tackling this @myabc ! I believe this is not your fault. This probably broke with the updates that were necessary for blocknote 0.39. And it is a sign that we need more tests here so that things like this do not get overseen. |
It's not urgent. However if you want to tackle it together, we could pair on Wednesday. I'll ping you. |
judithroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, whatever I did on Monday evening, I think the problem was me, not the code 😄 I was able to package 0.0.7 and test it locally with your other branch that updates blocknote in OpenProject and it nearly works 🥳
When collaboration is enabled, there's still one issue after saving and re-opening the document, instead of the block with the workpackage, we get an empty editor and an error in the Console:

|
I still need to learn a bit more about how the versions affect each other, but Mantine/BlockNote/BNReact need to be in sync to work properly (I guess it's reasonable). I've tested locally the demo app and with OpenProject and found ways of making it work. Will create a counterpart PR on OpenProject once this one gets merged. |
brunopagno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda approving my own changes here, but @myabc can double check to see if there's any alert~
See related downstream PR: opf/openproject#20367
See TypeCellOS/BlockNote#2033