Release OpenProject 12.0.7

Author: oliverguenther

app/controllers/wiki_controller.rb

@@ -341,13 +341,13 @@ def current_menu_item_sym(page)
     page = page_for_menu_item(page)
 
     menu_item = page.try(:menu_item)
+    return menu_item.menu_identifier if menu_item.present?
+    return unless page
 
-    if menu_item.present?
-      menu_item.menu_identifier
-    elsif page.present?
-      menu_item = default_menu_item(page)
-      "no-menu-item-#{menu_item.menu_identifier}".to_sym
-    end
+    default_item = default_menu_item(page)
+    return unless default_item
+
+    "no-menu-item-#{default_item.menu_identifier}".to_sym
   end
 
   private

app/controllers/wiki_menu_items_controller.rb

@@ -34,7 +34,7 @@ class WikiMenuItemsController < ApplicationController
   include Redmine::MenuManager::WikiMenuHelper
 
   current_menu_item :edit do |controller|
-    next controller.wiki_menu_item.menu_identifier if controller.wiki_menu_item.persisted?
+    next controller.wiki_menu_item.menu_identifier if controller.wiki_menu_item.try(:persisted?)
 
     project = controller.instance_variable_get(:@project)
     if (page = WikiPage.find_by(wiki_id: project.wiki.id, slug: controller.params[:id]))
@@ -52,6 +52,8 @@ class WikiMenuItemsController < ApplicationController
 
   def self.default_menu_item(controller, page)
     menu_item = controller.default_menu_item(page)
+    return unless menu_item
+
     "no-menu-item-#{menu_item.menu_identifier}".to_sym
   end
 

app/models/queries/notifications/notification_query.rb

@@ -34,6 +34,6 @@ def self.model
   end
 
   def default_scope
-    Notification.recipient(user)
+    Notification.visible(User.current).recipient(user)
   end
 end

app/models/repository.rb

@@ -285,7 +285,7 @@ def find_committer_user(committer)
       elsif committer.strip =~ /\A([^<]+)(<(.*)>)?\z/
         username = $1.strip
         email = $3
-        u = User.find_by_login(username)
+        u = User.by_login(username).first
         u ||= User.find_by_mail(email) unless email.blank?
         user = u
       end

app/views/admin/settings/api_settings/show.html.erb

@@ -29,6 +29,14 @@ See COPYRIGHT and LICENSE files for more details.
 <%= toolbar title: t(:label_api_access_key_type) %>
 
 <%= styled_form_tag(admin_settings_update_api_path, method: :patch) do %>
+  <section class="form--section">
+    <div class="form--field">
+      <%= setting_number_field :apiv3_max_page_size, min: 50, container_class: '-slim' %>
+      <div class="form--field-instructions">
+        <p><%= t(:setting_apiv3_max_page_instructions_html) %></p>
+      </div>
+    </div>
+  </section>
   <section class="form--section">
     <fieldset class="form--fieldset">
       <legend class="form--fieldset-legend"><%= I18n.t("setting_apiv3_docs") %></legend>

config/locales/crowdin/af.yml

@@ -752,6 +752,8 @@ af:
               group_without_name: "Unnamed groups are not allowed."
         user:
           attributes:
+            base:
+              user_limit_reached: "User limit reached. No more accounts can be created on the current plan."
             password_confirmation:
               confirmation: "Password confirmation does not match password."
               format: "%{message}"
@@ -2341,6 +2343,9 @@ af:
   setting_apiv3_cors_origins: "API V3 Cross-Origin Resource Sharing (CORS) allowed origins"
   setting_apiv3_cors_origins_text_html: >
     If CORS is enabled, these are the origins that are allowed to access OpenProject API. <br/> Please check the <a href="%{origin_link}" target="_blank">Documentation on the Origin header</a> on how to specify the expected values.
+  setting_apiv3_max_page_size: "Maximum API page size"
+  setting_apiv3_max_page_instructions_html: >
+    Set the maximum page size the API will respond with. It will not be possible to perform API requests that return more values on a single page. <br/> <strong>Warning:</strong> Please only change this value if you are sure why you need it. Setting to a high value will result in significant performance impacts, while a value lower than the per page options will cause errors in paginated views.
   setting_apiv3_docs: "Dokumentasie"
   setting_apiv3_docs_enabled: "Enable docs page"
   setting_apiv3_docs_enabled_instructions_html: >

config/locales/crowdin/ar.yml

@@ -756,6 +756,8 @@ ar:
               group_without_name: "Unnamed groups are not allowed."
         user:
           attributes:
+            base:
+              user_limit_reached: "User limit reached. No more accounts can be created on the current plan."
             password_confirmation:
               confirmation: "Password confirmation does not match password."
               format: "%{message}"
@@ -2415,6 +2417,9 @@ ar:
   setting_apiv3_cors_origins: "API V3 Cross-Origin Resource Sharing (CORS) allowed origins"
   setting_apiv3_cors_origins_text_html: >
     If CORS is enabled, these are the origins that are allowed to access OpenProject API. <br/> Please check the <a href="%{origin_link}" target="_blank">Documentation on the Origin header</a> on how to specify the expected values.
+  setting_apiv3_max_page_size: "Maximum API page size"
+  setting_apiv3_max_page_instructions_html: >
+    Set the maximum page size the API will respond with. It will not be possible to perform API requests that return more values on a single page. <br/> <strong>Warning:</strong> Please only change this value if you are sure why you need it. Setting to a high value will result in significant performance impacts, while a value lower than the per page options will cause errors in paginated views.
   setting_apiv3_docs: "التوثيق"
   setting_apiv3_docs_enabled: "Enable docs page"
   setting_apiv3_docs_enabled_instructions_html: >

config/locales/crowdin/az.yml

@@ -752,6 +752,8 @@ az:
               group_without_name: "Unnamed groups are not allowed."
         user:
           attributes:
+            base:
+              user_limit_reached: "User limit reached. No more accounts can be created on the current plan."
             password_confirmation:
               confirmation: "Password confirmation does not match password."
               format: "%{message}"
@@ -2341,6 +2343,9 @@ az:
   setting_apiv3_cors_origins: "API V3 Cross-Origin Resource Sharing (CORS) allowed origins"
   setting_apiv3_cors_origins_text_html: >
     If CORS is enabled, these are the origins that are allowed to access OpenProject API. <br/> Please check the <a href="%{origin_link}" target="_blank">Documentation on the Origin header</a> on how to specify the expected values.
+  setting_apiv3_max_page_size: "Maximum API page size"
+  setting_apiv3_max_page_instructions_html: >
+    Set the maximum page size the API will respond with. It will not be possible to perform API requests that return more values on a single page. <br/> <strong>Warning:</strong> Please only change this value if you are sure why you need it. Setting to a high value will result in significant performance impacts, while a value lower than the per page options will cause errors in paginated views.
   setting_apiv3_docs: "Documentation"
   setting_apiv3_docs_enabled: "Enable docs page"
   setting_apiv3_docs_enabled_instructions_html: >

config/locales/crowdin/bg.yml

@@ -752,6 +752,8 @@ bg:
               group_without_name: "Unnamed groups are not allowed."
         user:
           attributes:
+            base:
+              user_limit_reached: "User limit reached. No more accounts can be created on the current plan."
             password_confirmation:
               confirmation: "Password confirmation does not match password."
               format: "%{message}"
@@ -2341,6 +2343,9 @@ bg:
   setting_apiv3_cors_origins: "API V3 Cross-Origin Resource Sharing (CORS) позволява разрешения"
   setting_apiv3_cors_origins_text_html: >
     Ако CORS е активиран, това са източниците, на които е разрешен достъп до API на OpenProject. <br/> Моля, проверете <a href="%{origin_link}" target="_blank"> Документацията в заглавието Origin </a> за това как да посочите очакваните стойности.
+  setting_apiv3_max_page_size: "Maximum API page size"
+  setting_apiv3_max_page_instructions_html: >
+    Set the maximum page size the API will respond with. It will not be possible to perform API requests that return more values on a single page. <br/> <strong>Warning:</strong> Please only change this value if you are sure why you need it. Setting to a high value will result in significant performance impacts, while a value lower than the per page options will cause errors in paginated views.
   setting_apiv3_docs: "Документация"
   setting_apiv3_docs_enabled: "Enable docs page"
   setting_apiv3_docs_enabled_instructions_html: >

config/locales/crowdin/ca.yml

@@ -749,6 +749,8 @@ ca:
               group_without_name: "Unnamed groups are not allowed."
         user:
           attributes:
+            base:
+              user_limit_reached: "User limit reached. No more accounts can be created on the current plan."
             password_confirmation:
               confirmation: "La confirmació de la contrasenya no coincideix."
               format: "%{message}"
@@ -2336,6 +2338,9 @@ ca:
   setting_apiv3_cors_origins: "API V3 Cross-Origin Resource Sharing (CORS) allowed origins"
   setting_apiv3_cors_origins_text_html: >
     If CORS is enabled, these are the origins that are allowed to access OpenProject API. <br/> Please check the <a href="%{origin_link}" target="_blank">Documentation on the Origin header</a> on how to specify the expected values.
+  setting_apiv3_max_page_size: "Maximum API page size"
+  setting_apiv3_max_page_instructions_html: >
+    Set the maximum page size the API will respond with. It will not be possible to perform API requests that return more values on a single page. <br/> <strong>Warning:</strong> Please only change this value if you are sure why you need it. Setting to a high value will result in significant performance impacts, while a value lower than the per page options will cause errors in paginated views.
   setting_apiv3_docs: "Documentació"
   setting_apiv3_docs_enabled: "Enable docs page"
   setting_apiv3_docs_enabled_instructions_html: >