Feature/58161 global stage administration #17358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toy
force-pushed
the
feature/58161-global-stage-administration
branch
6 times, most recently
from
799692d to
516961c
Compare
ulferts
reviewed
Dec 12, 2024
toy
force-pushed
the
feature/58161-global-stage-administration
branch
3 times, most recently
from
01f3ec8 to
9d10847
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
toy
changed the base branch from
dev
to
feature/58163-project-specific-stage-administration
toy
force-pushed
the
feature/58161-global-stage-administration
branch
2 times, most recently
from
b5aa03b to
ef3ae5d
Compare
Base automatically changed from
feature/58163-project-specific-stage-administration
to
dev
December 16, 2024 08:37
toy
force-pushed
the
feature/58161-global-stage-administration
branch
from
312461a to
01e2e41
Compare
ulferts
reviewed
Dec 17, 2024
ulferts
requested changes
Dec 17, 2024
app/components/settings/project_life_cycle_step_definitions/form_header_component.html.erb
Outdated
Show resolved
Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb
Outdated
Show resolved
Hide resolved
app/components/settings/project_life_cycle_step_definitions/row_component.html.erb
Show resolved
Hide resolved
app/components/settings/project_life_cycle_step_definitions/row_component.html.erb
Show resolved
Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb
Outdated
Show resolved
Hide resolved
app/views/admin/settings/project_life_cycle_step_definitions/form.html.erb
Outdated
Show resolved
Hide resolved
toy
force-pushed
the
feature/58161-global-stage-administration
branch
2 times, most recently
from
b63fae5 to
d66c408
Compare
toy
force-pushed
the
feature/58161-global-stage-administration
branch
4 times, most recently
from
a85a8a0 to
57a392e
Compare
ulferts
requested changes
Dec 18, 2024
Contributor
ulferts
left a comment
ulferts
left a comment
There was a problem hiding this comment.
I only found one thing that actually needs fixing and that one is tiny.
db/migrate/20241217190533_add_uniqueness_index_to_project_life_cycle_step_definitions_name.rb
Show resolved
Hide resolved
app/components/projects/settings/life_cycle_steps/step_component.html.erb
Show resolved
Hide resolved
lookbook/previews/open_project/enterprise_edition/banner_component_preview.rb
Show resolved
Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb
Outdated
Show resolved
Hide resolved
toy
force-pushed
the
feature/58161-global-stage-administration
branch
2 times, most recently
from
1eaf7b3 to
43183be
Compare
…n name is too long
…use path to have shorter url
Co-authored-by: Tobias Dillmann <EinLama@users.noreply.github.com>
toy
force-pushed
the
feature/58161-global-stage-administration
branch
from
416b493 to
63ecbe0
Compare
ulferts
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#58161
What are you trying to accomplish?
Allow global stage administration
Merge checklist