Skip to content

Feature/66343 comment fields for project attributes#21452

Merged
toy merged 108 commits intodevfrom
feature/64264-comment-fields-for-project-attributes
Feb 25, 2026
Merged

Feature/66343 comment fields for project attributes#21452
toy merged 108 commits intodevfrom
feature/64264-comment-fields-for-project-attributes

Conversation

@toy
Copy link
Copy Markdown
Contributor

@toy toy commented Dec 15, 2025 •
edited
Loading

Ticket

https://community.openproject.org/wp/66343 (originally https://community.openproject.org/wp/64264)

What are you trying to accomplish?

Allow to comment project attributes

Leftovers

  • Tests:
    • Feature tests for project overview (modules/overviews/app/components/overviews/project_custom_fields/* + modules/overviews/app/controllers/overviews/project_custom_fields_controller.rb)
    • app/models/custom_field.rb : test can_have_comment? and comment_for
    • lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb - tested implicitly, but better to test expected behaviour for project as having comment and work package as not having them
  • API docs for the newly introduced custom comment fields
  • Decide if custom comments functionality should stay in acts as customizable or be moved to Projects::CustomFields
  • N+1 when exporting project query is still present

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 3 times, most recently from d6d9bcd to 7b1dd29 Compare December 19, 2025 21:35
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 3 times, most recently from d96b04a to 3ca06f4 Compare January 8, 2026 16:11
@toy toy mentioned this pull request Jan 8, 2026
Merged
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 3ca06f4 to 53e8534 Compare January 8, 2026 20:50
@toy toy mentioned this pull request Jan 9, 2026
Merged
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 2 times, most recently from 22dc532 to 8fc8b9f Compare January 15, 2026 17:47
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 15, 2026 18:22 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 8fc8b9f to 406b2ff Compare January 19, 2026 19:44
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 19, 2026 19:44 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 406b2ff to 8fc1727 Compare January 20, 2026 20:04
@github-actions github-actions bot requested a deployment to gh-6899875-pr-21452 January 20, 2026 20:05 Pending
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 8fc1727 to fc6b5c8 Compare January 26, 2026 20:40
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 26, 2026 20:40 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from fc6b5c8 to 26c4df2 Compare January 28, 2026 20:27
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 28, 2026 20:27 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 26c4df2 to 0e1b24b Compare January 29, 2026 13:19
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 29, 2026 13:20 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 29, 2026 21:20 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from ad81a62 to c7956ed Compare February 2, 2026 20:56
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 February 2, 2026 23:18 Inactive
toy and others added 28 commits February 25, 2026 20:07
@toy
test custom comment form field
d29cdad
@toy
test custom comment injection into api
881fc34
@toy
use wait_for_network_idle instead of wait_for_reload in projects inde…
7fd844b 
…x spec
@toy
use complete label for comment field if there are multiple custom fie…
5e1702e 
…lds rendered
@toy
cleanup additional css classes for project index columns
94bd162 
Usage of project-long-text-container is nowhere to be found
@toy
test rendering custom comments fields
e4552e9
@toy
test custom value inputs using public method
baf412c
@toy
test CustomField comment attribute name methods
e2e3d2f
@toy
use bang versions of update/save/destroy in project acts_as_journaliz…
8a186af 
…ed tests
@toy
auto enable custom field for project when creating custom comment
e849ff5
@toy
test journaling custom comments
4cb8f98
@toy
test custom comments journal formatter
fb101c2
@toy
rework test for journaling custom values
952b414
@toy
test Redmine::Acts::Customizable::HumanAttributeName
c39734c
@toy
remove auto enabling custom field for project when creating custom co…
cb42aad 
…mment
@toy
test presence of UTF-8 BOM mark in CSV separately
a9bb7e6
@toy
reuse defined permissions when testing without view_project_attributes
ade2133
@toy
unit test for custom comment export formatter
9d4e81c
@toy
make project created for version as inactive to remove it from query
656dd5b
@toy
test pdf export with custom fields by admin
9e0226e
@toy
integration tests for custom comments export
487f8f2
@toy
don't use local variables automatically populated for named capture g…
5bdf9f9 
…roups
@toy
handle delete custom fields in human attribute name
6a8975b
@toy
use the object.custom_comment_for(cf) instead of cf.comment_for(object)
efa709c 
As comments are built on object size, they will be present after failed
validation, but for comments from the custom field side they will be
queried from DB, so will not be the built ones
@toy
eager load custom comments in query exporter
eb81b20
@toy
rework readonly_attribute_errors variable in project update contract …
0838ec3 
…spec
@toy @dombesz
Use stringify_keys instead of transform_keys(&:to_s)
807c1bc 
Co-authored-by: Dombi Attila <83396+dombesz@users.noreply.github.com>
@toy
consistent camel casting custom field injector fields, otherwise it i…
82086a3 
…s done automatically
Copilot AI reviewed Feb 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 82 out of 83 changed files in this pull request and generated 2 comments.

@toy
Copy link
Copy Markdown
Contributor Author

toy commented Feb 25, 2026

@dombesz Thank you for review, I'll create tickets or notes to discuss for the leftovers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dombesz dombesz dombesz approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@toy @dombesz @ulferts @lindenthal