[#70107] Required project attributes not enforced on POST /api/v3/projects #21576
+74
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EinLama
changed the title
dombesz
force-pushed
the
bug/70107-required-project-attributes-not-enforced-on-post-api-v3-projects
branch
from
bca7e73 to
7e9b1bf
Compare
Next step: make it green
… flag on project creation.
… instead of the model level.
dombesz
force-pushed
the
bug/70107-required-project-attributes-not-enforced-on-post-api-v3-projects
branch
from
7e3d710 to
feaec0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/70107
What are you trying to accomplish?
Fix the project creation api endpoint erroneously skipping required custom field validations.
What approach did you choose and why?
Update the
BaseServices::SetAttributes#set_custom_values_to_validateto validate all custom field values when the record is not persisted, while validating user-provided custom field values when the record is persisted. This is in line with the specification.Merge checklist