Skip to content

[72657] Make banners smaller so they do not block important content#22271

Merged
HDinger merged 3 commits intodevfrom
feature/72657-move-banners-to-bottom-right-of-the-screen-so-it-does-not-block-important-content
Mar 19, 2026
Merged

[72657] Make banners smaller so they do not block important content#22271
HDinger merged 3 commits intodevfrom
feature/72657-move-banners-to-bottom-right-of-the-screen-so-it-does-not-block-important-content

Conversation

@HDinger
Copy link
Contributor

@HDinger HDinger commented Mar 9, 2026

Ticket

https://community.openproject.org/wp/72657

What are you trying to accomplish?

  • Decrease the size of all banners (Angular and rails) The position remains for now
  • Move the actions (primary and secondary) to a new line if the banner is smaller than 540px
  • The banner should remain in that position and not scroll with the rest of the page

Screenshots

Before

Bildschirmfoto 2026-03-11 um 11 50 38

After

Bildschirmfoto 2026-03-11 um 11 49 11

@HDinger HDinger added this to the 17.3.x milestone Mar 9, 2026
@HDinger HDinger added the feature label Mar 9, 2026
@HDinger HDinger force-pushed the feature/72657-move-banners-to-bottom-right-of-the-screen-so-it-does-not-block-important-content branch from 2a70a3f to babcaf1 Compare March 11, 2026 10:45
@HDinger HDinger changed the title [72657] Move banners to bottom-right of the screen so it does not block important content [72657] Make banners smaller so they do not block important content Mar 11, 2026
@HDinger HDinger force-pushed the feature/72657-move-banners-to-bottom-right-of-the-screen-so-it-does-not-block-important-content branch from babcaf1 to fcc74a7 Compare March 11, 2026 11:10
@HDinger HDinger marked this pull request as ready for review March 11, 2026 11:10
@HDinger HDinger requested a review from bsatarnejad March 11, 2026 11:11
@myabc
Copy link
Contributor

myabc commented Mar 13, 2026

@HDinger just a thought that came to be my while travelling - will this work ok on mobile? I'm thinking login screen in particular.


.op-primer-flash
@include banner-styles
z-index: 599
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you keep the z-index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will overwrite the one from the mixin. I kept it, because the number is so oddly specific that I assumed it was put to that for a reason. 🤷‍♂️

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Deploying openproject with PullPreview

Field Value
Latest commit 46d79f6
Job deploy
Status ✅ Deploy successful
Preview URL https://pr-22271-72657-move-banners-ip-78-47-22-73.my.opf.run:443

View logs

@HDinger HDinger merged commit 94dd914 into dev Mar 19, 2026
16 checks passed
@HDinger HDinger deleted the feature/72657-move-banners-to-bottom-right-of-the-screen-so-it-does-not-block-important-content branch March 19, 2026 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants