[#72239] Workflows UX improvement: Select relevant roles and statuses by mrmir · Pull Request #22325 · opf/openproject

mrmir · 2026-03-12T16:52:53Z

Ticket

https://community.openproject.org/work_packages/72239

What approach did you choose and why?

The workflows matrix now shows only relevant workflows for a particular type, role, tab combination. The default view for a selected type is to see the matrix for the first available role in the default transitions tab
The matrix is now enclosed in a turbo frame that gets updated on changes to the role/statuses
Statuses are managed via an autocompleter in a dialog. These changes only affect the current view and are not saved to the DB directly
There is a stimulus controller to save/restore checked state when updating statuses, since nothing is saved until "Save" is clicked on the form. Changes to the checkboxes are currently only kept for status updates. Role updates and switching tabs will lose them, but this will have a warning/confirmation dialog in the future
The matrix styling has been updated to handle shorter tables. Also, there is a blankslate when no rows/columns are displayed for a particular type, role, tab combo
The menu entries for work packages settings have been pluralized to maintain consistency

Merge checklist

Added/updated tests
Added/updated documentation in Lookbook (patterns, previews, etc)
Tested major browsers (Chrome, Firefox, Edge, ...)

…y-type' into feature/72239-workflows-ux-improvement-select-relevant-statuses

Before, the statuses in the list were only those read from the DB. Thus, adding/removing statuses and clicking apply did not update the list before saving the entire form

…y-type' into feature/72239-workflows-ux-improvement-select-relevant-statuses

…ows-ux-improvement-select-relevant-statuses

HDinger

Nice 👍 🌟
When playing around I noticed some issues:

The Subheader is part of the scrollable area resulting in something like this:

The dialog to select statuses is too small. I know that you added the class, but given that the autocompleter will grow very quickly, this is not enough.

I somewhow expected that a change in role would change the URL. Currently, when I change the role, and reload (or change the tab), the role selection is lost.
In the ticket it says: "When the page is saved with one status completely unused (no checkboxes checked for its row/column), it is removed on save." This is not happening:

HDinger · 2026-03-23T08:53:35Z

app/components/workflows/status_form_component.html.erb

+        role: @role,
+        type: @type,
+        tab: @tab,
+        dialog_id: dialog_id


nitpick:

Suggested change

dialog_id: dialog_id

dialog_id:

HDinger · 2026-03-23T08:57:40Z

app/components/workflows/status_removal_danger_dialog_component.html.erb

+    dialog.with_additional_details do
+      concat(hidden_field_tag(:role_id, @role.id))
+      concat(hidden_field_tag(:tab, @tab))
+      @status_ids.each { |id| concat(hidden_field_tag("status_ids[]", id)) }
+    end


I think this does not belong here. The dangerDialog is to get users confirmation (or if necessary decide what to do with related objects). These hidden objects should however be part of the original form request.

I'm not sure how else to pass these params. The reason I added them here was because the status dialog "Apply" is not saving anything to the DB. So in the case where something is removed and the danger dialog is shown, the new info (statuses) needs to be passed through the dialog. Otherwise the params reaching WorkflowsController#confirm_statuses (on dialog "Apply") are lost

HDinger · 2026-03-23T09:01:19Z

app/controllers/workflows_controller.rb

                end
  end

+  def role_type_statuses


Might be a personal preference, but the name could probably be better explaining.. Maybe statuses_for_role_and_type or something similar?

HDinger · 2026-03-23T09:20:42Z

config/locales/en.yml

+        title: "Statuses"
+        label: "Statuses enabled for this type"
+        caption: "Add or remove statuses you would like to associate with this type. Removing a status will also delete the workflow associated with it."
+        apply: "Apply"


We already have a generic "apply" string (button_apply). Is it really necessary to add a new one here?

Nope, changed it

HDinger · 2026-03-23T09:23:25Z

config/locales/en.yml

+        caption: "Add or remove statuses you would like to associate with this type. Removing a status will also delete the workflow associated with it."
+        apply: "Apply"
+      statuses_removal_dialog:
+        title: "Remove statuses?"


I vaguely remember, that we once decided in the D-Team to follow the pattern of adding the question mark only to the visible title, not the one that is read out by screenreaders. So that would mean:

Suggested change

title: "Remove statuses?"

title: "Remove statuses"

HDinger · 2026-03-23T09:56:39Z

app/components/workflows/edit_sub_header_component.html.erb

+  render Primer::OpenProject::SubHeader.new do |subheader|
+    if @type && @available_roles.any?
+      subheader.with_filter_component do
+        render(Primer::Alpha::ActionMenu.new(select_variant: :single)) do |menu|


According to the figma comment, this should be a SelectPanel and not an action menu

Hmm in the WP AC it was either SelectPanel or ActionMenu, and I updated it to be ActionMenu since that made more sense to me. Since it was an either/or, I think this is fine too?

frontend/src/stimulus/controllers/dynamic/admin/workflow-checkbox-state.controller.ts

mrmir · 2026-03-23T16:25:52Z

In the ticket it says: "When the page is saved with one status completely unused (no checkboxes checked for its row/column), it is removed on save." This is not happening:

This is generally happening for me and there's also a test that covers this case. Is there something specific about the case where it doesn't work for you?

mrmir · 2026-03-23T17:56:33Z

I made changes according to your feedback and left some clarification questions, so please take another look

mrmir added 2 commits March 12, 2026 17:52

Show role specific statuses on workflow edit page by default

cf24316

Add new dialogs to manage and remove statuses

24de72b

mrmir force-pushed the feature/72239-workflows-ux-improvement-select-relevant-statuses branch from 6548db3 to 24de72b Compare March 13, 2026 09:43

mrmir added the pullpreview label Mar 13, 2026

This comment was marked as outdated.

Sign in to view

mrmir added 2 commits March 13, 2026 15:02

Merge branch 'feature/72234-workflows-ux-improvement-show-workflows-b…

7718a0c

…y-type' into feature/72239-workflows-ux-improvement-select-relevant-statuses

Update role selector

72d54a8

mrmir removed the pullpreview label Mar 13, 2026

Show different status matrices per tab

cfafd01

mrmir changed the base branch from dev to epic/workflows-ux-quick-wins March 17, 2026 16:56

mrmir added 8 commits March 18, 2026 11:27

Keep checked state when updating statuses

590a793

Pluralize work package settings menu labels

d9658ac

Show updated list of statuses in status dialog on apply

bbf271a

Before, the statuses in the list were only those read from the DB. Thus, adding/removing statuses and clicking apply did not update the list before saving the entire form

Check all new checkboxes on adding a new status

e1f8fd9

Merge branch 'feature/72234-workflows-ux-improvement-show-workflows-b…

465d7a1

…y-type' into feature/72239-workflows-ux-improvement-select-relevant-statuses

Merge branch 'epic/workflows-ux-quick-wins' into feature/72239-workfl…

0d2b684

…ows-ux-improvement-select-relevant-statuses

Add and update specs

4c7d03b

Update stimulus controller to use single session storage key

5be719d

mrmir force-pushed the feature/72239-workflows-ux-improvement-select-relevant-statuses branch from 363121d to 5be719d Compare March 19, 2026 13:38

mrmir marked this pull request as ready for review March 19, 2026 14:50

HDinger requested changes Mar 23, 2026

View reviewed changes

mrmir added 2 commits March 23, 2026 17:20

Fix scrolling

35aedd0

Increase status dialog height

83e74a9

mrmir added 2 commits March 23, 2026 18:34

Keep current role when reloading

9ac7ccd

Incorporate PR feedback

1c50c8b

mrmir requested a review from HDinger March 23, 2026 17:55

Conversation

mrmir commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ticket

What approach did you choose and why?

Merge checklist

Uh oh!

This comment was marked as outdated.

HDinger left a comment • edited by mrmir Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrmir commented Mar 23, 2026

Uh oh!

mrmir commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

mrmir commented Mar 12, 2026 •

edited

Loading

HDinger left a comment •

edited by mrmir

Loading