[#73389] Clean up controllers and routing constraints

[myabc]

Ticket

https://community.openproject.org/wp/73389

What are you trying to accomplish?

Splits dual-mode backlogs controllers that mix legacy and new scrum-project code (behind the scrum_projects feature flag) into clean, separate controllers:

• Legacy controllers (Rb*Controller) — stripped of all feature-flag branches, only serve legacy paths
• New controllers (Agile::*Controller) — dedicated controllers for sprint planning, sprints, stories, and taskboards

This eliminates flag-conditional logic scattered across controllers, making each controller single-purpose and easier to reason about.

New controllers created

Controller	Responsibility
Agile::BaseController	Shared setup (project/sprint loading, authorization)
Agile::SprintPlanningController	Sprint planning page + split-view details
Agile::SprintsController	Sprint CRUD and lifecycle (start/finish)
Agile::StoriesController	Story move action
Agile::TaskboardsController	Taskboard redirect shim

Screenshots

N/A — no UI changes. All existing URLs and behavior are preserved.

What approach did you choose and why?

URL-preserving routing with scope module: — the new Agile:: controllers are routed behind the existing Constraints::FeatureDecision routing constraint, using scope module: "agile" so URL paths remain unchanged. Legacy route nesting is mirrored to preserve named route helpers (e.g. sprint_planning_backlogs_project_backlogs_path). Only one URL helper needed updating (NewSprintFormComponent).

Views were moved via git mv from rb_master_backlogs/ to agile/sprint_planning/ with no content changes.

Permission registrations in engine.rb were extended to include the new controller paths alongside the existing rb_* entries.

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook
• Tested major browsers

[Copilot]

Pull request overview

This PR refactors the Backlogs “scrum_projects” feature-flagged endpoints by moving the new Scrum functionality into dedicated Agile::* controllers and routing it via a route constraint, while simplifying the legacy Rb* controllers by removing feature-flag branches. It also updates permissions and specs accordingly.

Changes:

• Introduce Agile::* controllers (sprint planning, sprints, stories, taskboards) and route them only when scrum_projects is active.
• Simplify legacy Rb* controllers by removing feature-flagged code paths and shifting specs to the new controllers.
• Extend Backlogs permission mappings and update form routing for sprint update.

Reviewed changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
modules/backlogs/spec/routing/rb_stories_routing_spec.rb	Removes feature-flag routing assertions for the old stories move endpoint.
modules/backlogs/spec/routing/rb_sprints_routing_spec.rb	Adjusts legacy sprint routing expectations to the flag-inactive case.
modules/backlogs/spec/routing/agile/taskboards_routing_spec.rb	Adds routing coverage for the new agile taskboard endpoint under the flag.
modules/backlogs/spec/routing/agile/stories_routing_spec.rb	Adds routing coverage for the new agile stories move endpoint.
modules/backlogs/spec/routing/agile/sprints_routing_spec.rb	Adds routing coverage for the new agile sprints endpoints (incl. named routes).
modules/backlogs/spec/routing/agile/sprint_planning_routing_spec.rb	Adds routing coverage for the new sprint planning controller and legacy fallback.
modules/backlogs/spec/controllers/rb_taskboards_controller_spec.rb	Removes feature-flag-active behavior tests from the legacy controller spec.
modules/backlogs/spec/controllers/rb_stories_controller_spec.rb	Removes feature-flag-active move tests from the legacy controller spec.
modules/backlogs/spec/controllers/rb_sprints_controller_spec.rb	Removes feature-flag-active sprint CRUD/lifecycle tests from the legacy controller spec.
modules/backlogs/spec/controllers/agile/taskboards_controller_spec.rb	Adds controller specs for the new agile taskboards controller.
modules/backlogs/spec/controllers/agile/sprints_controller_spec.rb	Adds controller specs for the new agile sprints controller.
modules/backlogs/lib/open_project/backlogs/engine.rb	Extends permission mappings to include the new agile/* controllers/actions.
modules/backlogs/config/routes.rb	Adds constrained routes for agile controllers; keeps legacy routes outside constraint.
modules/backlogs/app/views/agile/sprint_planning/show.html.erb	Adds new sprint planning page wrapper rendering a turbo-frame list.
modules/backlogs/app/views/agile/sprint_planning/_sprint_planning_list.html.erb	Adds the new sprint planning list partial (frame content).
modules/backlogs/app/views/agile/sprint_planning/_agile_list.html.erb	Adds an additional list partial (currently appears unused).
modules/backlogs/app/controllers/rb_taskboards_controller.rb	Removes feature-flag branch; legacy controller now only serves legacy sprint taskboard.
modules/backlogs/app/controllers/rb_stories_controller.rb	Removes agile move action; keeps legacy move/reorder and simplifies turbo stream updates.
modules/backlogs/app/controllers/rb_sprints_controller.rb	Removes feature-flagged agile sprint CRUD/lifecycle endpoints from legacy controller.
modules/backlogs/app/controllers/rb_master_backlogs_controller.rb	Removes sprint planning behavior and feature-flag redirects from legacy controller.
modules/backlogs/app/controllers/rb_application_controller.rb	Removes feature-flag branching from sprint loading and plugin configuration check.
modules/backlogs/app/controllers/agile/taskboards_controller.rb	Adds new taskboards controller for flagged behavior (board redirect).
modules/backlogs/app/controllers/agile/stories_controller.rb	Adds new stories controller for flagged move behavior (turbo streams).
modules/backlogs/app/controllers/agile/sprints_controller.rb	Adds new sprints controller for flagged CRUD/lifecycle (dialogs, start/finish).
modules/backlogs/app/controllers/agile/sprint_planning_controller.rb	Adds new sprint planning controller handling list + split view details.
modules/backlogs/app/controllers/agile/base_controller.rb	Adds shared base controller for agile backlogs endpoints (project/sprint loading + authorize).
modules/backlogs/app/components/backlogs/new_sprint_form_component.rb	Updates sprint update URL to use the new standard project_sprint_path.

[myabc]

⚠️ This has the potential to introduce n+1 queries in this component!

[myabc]

I think this can be removed?

[Copilot]

Pull request overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

modules/backlogs/app/controllers/rb_stories_controller.rb:121

• RbStoriesController#move is now described/implemented as moving between version-backed sprint containers, and it only updates the target UI for version moves. However, infer_attributes_from_target still accepts target_type == "sprint" and will set sprint_id, which can move a story into an Agile sprint (e.g., when target_id comes from Backlogs::SprintComponent's sprint: target ids). In that case the action won’t render a success flash/target component update, and it also reintroduces a path to mutate Agile sprint assignments through the legacy controller. If this controller is intended to be version-only, reject/raise on target_type == "sprint" (or otherwise fully handle sprint targets here).

  def infer_attributes_from_target
    target_type, target_id = move_params[:target_id].split(":")

    case target_type
    when "version"
      { version_id: target_id, sprint_id: nil }
    when "sprint"
      # If the story is assigned to a version, we will only nullify the version
      # if it is used as a backlog. We will keep a "regular" version reference.
      # Otherwise, moving a story to a sprint would delete it from any version it is
      # assigned to.
      if @story.version&.used_as_backlog?
        { version_id: nil, sprint_id: target_id }
      else
        { sprint_id: target_id }
      end
    else
      raise ArgumentError, "target_type must include one of: version, sprint."
    end

[Copilot]

load_backlogs runs as a before_action for #index, but #index immediately redirects when scrum_projects_active? is true. This means every visit to /projects/:id/backlogs in the new mode still executes the legacy backlog queries unnecessarily. Consider moving the redirect ahead of loading backlogs (e.g., perform the redirect in a separate before_action and skip load_backlogs when redirecting, or call load_backlogs inside #index only after the redirect guard).

[Copilot]

check_if_plugin_is_configured no longer skips execution when scrum_projects is active. This changes behavior compared to the previous guard and can interfere with the legacy controllers that now redirect in scrum mode (e.g., /projects/:id/backlogs), potentially rendering shared/not_configured (or causing a double-render/redirect situation) instead of performing the redirect. If the intent is still to bypass this check when scrum_projects is active, reintroduce the feature-flag guard; if the intent is to enforce the check, the equivalent check likely needs to live in Agile::BaseController as well so behavior is consistent across the new controllers.

[ulferts]

Hi @myabc I didn't review this yet since it is too big to review shortly before the feature freeze with us still having to finish a number of features.

I suggest we merge this after the feature freeze, when we have time for this. Then, we can merge it and remove the old controllers in one go, together with the feature flag.