Open
Conversation
7b180d7 to
4531309
Compare
…of changing owner after run
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Crowdin translation sync workflow to avoid file ownership fixes, normalize downloaded translation YAMLs, and simplify the Portuguese root-key correction script.
Changes:
- Switch Crowdin GitHub Action to an OPF fork and remove the post-download
chownstep. - Add a workflow step to rewrite downloaded Crowdin YAML files via a Ruby-based rewriter script.
- Refactor
fix_crowdin_pt_language_root_keyto centralize GNU/BSDsed -ihandling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
script/i18n/fix_crowdin_pt_language_root_key |
Refactors sed -i handling into a helper and runs the two substitutions via the helper. |
.github/workflows/crowdin.yml |
Switches to a forked Crowdin action, removes ownership-fix step, and adds a YAML rewrite step after download. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to crowdin workflow:
script/i18n/rewrite_crowdin_yml_files(script to rewrite yaml files using psych #22533 should be merged first, as script should be both in dev and latest release branches). This should simplify the logic in [#72881] Handle generated Crowdin conflicts in release-to-dev merges #22249script/i18n/fix_crowdin_pt_language_root_keya bit