[#73474] Make Inbox - Sprints divider full height#22534
[#73474] Make Inbox - Sprints divider full height#22534myabc wants to merge 1 commit intorelease/17.3from
Conversation
bdde411 to
9683692
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts Backlogs (sprint planning / inbox) layout styles to make the column divider span the full available height and to control overflow/scrolling within the lists.
Changes:
- Add flex container sizing/alignment rules to stretch the two-column layout vertically.
- Make backlog/sprint-planning list columns scrollable (
overflow-y: auto) withmin-height: 0for proper flexbox overflow behavior.
| height: 100% | ||
| align-items: stretch | ||
| overflow: hidden |
There was a problem hiding this comment.
height: 100% on .op-backlogs-container, .op-sprint-planning-container likely won’t have any effect because the direct parent (.op-backlogs-page) doesn’t define a height, so the percentage resolves to auto. If the intent is to stretch the columns (and the divider border) to the available viewport/content area height, set the height on .op-backlogs-page (or another ancestor with a definite height) and let the container/list flex items fill that space.
|
@HDinger as implemented, the divider still doesn't go full height - |
I did not have the time yet to look at the PR but to answer that already: We have a mixin called |
HDinger
left a comment
There was a problem hiding this comment.
The changes look good. Just the bottom spacing we already talked about is missing 👍
|
Given that one the tickets is a feature, either the target branch or the ticket type needs to be adapted.. |
9683692 to
e241922
Compare
This also begins the work needed for OP #73475. https://community.openproject.org/wp/73474 https://community.openproject.org/wp/73475
e241922 to
4270ce6
Compare
| flex: 1 1 100% | ||
| overflow: hidden | ||
| min-height: 0 | ||
| overflow-y: auto |
There was a problem hiding this comment.
Switching from overflow: hidden to overflow-y: auto on the list columns means horizontal overflow is no longer clipped at the column level. Long/unbroken content can now bleed into the gap/adjacent column. Consider also constraining horizontal overflow (e.g., keep overflow-x: hidden or otherwise ensure wide content can’t visually overlap neighboring columns) while retaining vertical scrolling.
| overflow-y: auto | |
| overflow-y: auto | |
| overflow-x: hidden |
Ticket
https://community.openproject.org/wp/73474
https://community.openproject.org/wp/73475
What are you trying to accomplish?
Make the vertical divider between the Inbox and Sprints columns extend to full height on the sprint planning page. Also begins groundwork for OP #73475.
Screenshots
What approach did you choose and why?
height: 100%on.op-backlogs-pageand.op-sprint-planning-containerto establish the full height chain from#content-wrapperdown to the flex columnsalign-items: stretchon the flex container so the border divider stretches to full heightmin-height: 0+overflow-y: autoon children to allow independent column scrolling (standard flexbox shrink pattern)overflow: hiddenfrom children to the containerextended-content--bottommixin (scoped to.action-sprint_planning) to remove#content-body's bottom padding so the layout fills the viewport edge; inner padding restored via--stack-padding-normalon.op-sprint-planning-lists@container (min-width: 655px)query so it only appears when columns are side-by-side, avoiding a specificity conflict with themax-width: 654pxstacking rule:first-childto:not(:last-child)for robustnessMerge checklist
height: 100%resolves correctly through the parent chain (divider reaches full height)