[#73511] Fix robots meta tag rendered as text instead of HTML element#22559
Open
wielinde wants to merge 1 commit intorelease/17.3from
Open
[#73511] Fix robots meta tag rendered as text instead of HTML element#22559wielinde wants to merge 1 commit intorelease/17.3from
wielinde wants to merge 1 commit intorelease/17.3from
Conversation
`content_tag(:meta, name:, content:)` treated the keyword arguments as text content rather than HTML attributes, producing visible JSON-like output on the page. Replace with `tag(:meta, ...)` which correctly renders a self-closing element with the proper attributes. Adds a view spec assertion to cover the rendered output.
Member
Author
|
@oliverguenther about a week ago you removed a lot of html_safe and I believe that this broke this little case here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the ROBOTS meta tag was rendered as visible text on the wiki page when no wiki pages exist yet in a project.
content_tag(:meta, name:, content:)withtag(:meta, ...)—content_tagtreated the keyword arguments as text content rather than HTML attributesWork package
https://community.openproject.org/projects/openproject/work_packages/73511/activity
Test plan
/projects/<id>/wikion a project with no wiki pages — no JSON-like text should appear at the top of the page