Skip to content

[#61347] Danger and Feedback Dialogs have broken ARIA describedby attribute value#245

Merged
HDinger merged 3 commits intomainfrom
fix/61347-danger-dialog-keyboard-accessibility
Feb 20, 2025
Merged

[#61347] Danger and Feedback Dialogs have broken ARIA describedby attribute value#245
HDinger merged 3 commits intomainfrom
fix/61347-danger-dialog-keyboard-accessibility

Conversation

@myabc
Copy link
Collaborator

@myabc myabc commented Feb 19, 2025

What are you trying to accomplish?

Fix broken ARIA describedby attribute value for the Danger and Feedback Dialogs.

Screenshots

Before

Screenshot 2025-02-20 at 09 35 16

After

Screenshot 2025-02-20 at 09 37 35

Integration

N/A

List the issues that this change affects.

https://community.openproject.org/wp/61347

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 27b6af1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@myabc myabc force-pushed the fix/61347-danger-dialog-keyboard-accessibility branch from 3d7bb23 to 5356e56 Compare February 19, 2025 15:18
@myabc myabc changed the title Fix/61347 danger dialog keyboard accessibility [#61347] Fix Danger Dialog keyboard accessibility Feb 19, 2025
@myabc myabc added bug Something isn't working work in progress Do not merge without further discussion labels Feb 19, 2025
@myabc myabc changed the title [#61347] Fix Danger Dialog keyboard accessibility [#61347] Danger Dialog has broken ARIA describedby attribute value Feb 20, 2025
@myabc myabc force-pushed the fix/61347-danger-dialog-keyboard-accessibility branch from 5356e56 to 27b6af1 Compare February 20, 2025 12:37
@myabc myabc changed the title [#61347] Danger Dialog has broken ARIA describedby attribute value [#61347] Danger and Feedback Dialogs have broken ARIA describedby attribute value Feb 20, 2025
@github-actions
Copy link

github-actions bot commented Feb 20, 2025

Uh oh! @myabc, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
  • Images should have meaningful alternative text (alt text) at line 9
  • Images should have meaningful alternative text (alt text) at line 13

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@myabc myabc marked this pull request as ready for review February 20, 2025 12:40
@myabc myabc removed the work in progress Do not merge without further discussion label Feb 20, 2025
@HDinger HDinger merged commit 56a0c9b into main Feb 20, 2025
38 checks passed
@HDinger HDinger deleted the fix/61347-danger-dialog-keyboard-accessibility branch February 20, 2025 12:49
@openprojectci openprojectci mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch release

Development

Successfully merging this pull request may close these issues.

2 participants