Skip to content

Fix merge-upstream script for macOS users#248

Closed
myabc wants to merge 1 commit intomainfrom
fix/merge-upstream-script
Closed

Fix merge-upstream script for macOS users#248
myabc wants to merge 1 commit intomainfrom
fix/merge-upstream-script

Conversation

@myabc
Copy link
Collaborator

@myabc myabc commented Feb 19, 2025

FreeBSD-based implementations of sed require an empty argument with the -i flag.

See SO comment: https://unix.stackexchange.com/a/36805

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 0228a31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myabc myabc requested a review from oliverguenther February 19, 2025 15:47
@myabc myabc force-pushed the fix/merge-upstream-script branch from aece441 to db0a44d Compare February 19, 2025 15:49
FreeBSD-based implementations of `sed` require an empty argument with
the `-i` flag.

See SO comment: https://unix.stackexchange.com/a/36805

[skip changeset]
@myabc myabc force-pushed the fix/merge-upstream-script branch from db0a44d to 0228a31 Compare February 19, 2025 15:49
@myabc
Copy link
Collaborator Author

myabc commented Feb 19, 2025

Hi @oliverguenther - would you mind checking this doesn't break anything for you?

@myabc myabc added the skip changeset For PRs that contain no relevant release data (e.g. documentation only) label Feb 19, 2025
@myabc myabc changed the title Fix merge-upstream script for macOS users Fix merge-upstream script for macOS users Feb 19, 2025
@oliverguenther
Copy link
Member

I'm also on Mac, so this won't help you. What we do in devops scripts is require Mac users to have gsed installed, check for its presence, and fail if you don't have it. This ensures parity, as sed has a lot of other edge cases where it doesn't behave identically, depending on the patterns.

@myabc
Copy link
Collaborator Author

myabc commented Feb 19, 2025

@oliverguenther thanks for the context. I'll go ahead and close this PR - and install gsed instead.

@myabc myabc closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset For PRs that contain no relevant release data (e.g. documentation only)

Development

Successfully merging this pull request may close these issues.

2 participants