[#69504] Port Primer React Text Field styling, removing trailing text truncation [OPF integration] #391
+241
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also renders clear button using an `IconButton`. Rough mapping: | Primer View Components | Primer React | | ----------------------------------------- | ---------------------------------------------------- | | `.FormControl-input-baseWrap` (new class) | `.TextInputBaseWrapper` | | `.FormControl-input-wrap` | `.TextInputWrapper` | | `.FormControl-input-trailingVisualWrap` | `.TextInput-icon` | | `.FormControl-input-leadingVisualWrap` | `.TextInput-icon` | | `.FormControl-input-trailingAction` | `.TextInput-icon` | | `.FormControl-input` | `input` | | `.FormControl-input-wrap--leadingVisual` | `[data-leading-visual]` | | `.FormControl-input-wrap--trailingVisual` | `[data-trailing-visual]:not([data-trailing-action])` | | `.FormControl-input-wrap--trailingAction` | `[data-trailing-action]` | | `.FormControl-input-wrap--small` | `[data-size='small']` | | `.FormControl-input-wrap--large` | `[data-size='large']` | Closes primer#3800 Closes primer#3802 Closes primer#3803
myabc
force-pushed
the
bug/69504-text-field-trailing-text-truncation-opf-integration
branch
from
efe6abe to
af11efa
Compare
myabc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salient commits from upstream PR primer#3801, cherry-picked onto our fork's main branch. This is primary so that we can use our own testing infrastructure to visual regression test.
TextField, e.g.input_sizesupport.OpenProject tickets
https://community.openproject.org/wp/69504