Skip to content

[#72454] Fix CollapsibleHeader title truncation when multi_line: false #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDinger merged 4 commits into from
Mar 3, 2026
+10 −2
Merged

[#72454] Fix CollapsibleHeader title truncation when multi_line: false #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2cefee
[#72454] Fix title truncation when multi_line: false
myabc Mar 3, 2026
716abb7
Add changeset
myabc Mar 3, 2026
a3faf44
Use fully-qualified Truncate constant
myabc Mar 3, 2026
f45501e
Generating component snapshots
myabc Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/easy-cobras-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openproject/primer-view-components': patch
---

Fix `CollapsibleHeader` title truncation when `multi_line: false`.
Binary file modified ...hots/primer/alpha/text_area/with_character_limit_over_limit/dark_colorblind.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t.ts-snapshots/primer/alpha/text_area/with_character_limit_over_limit/light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ots/primer/alpha/text_area/with_character_limit_over_limit/light_colorblind.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../primer/alpha/text_area/with_character_limit_over_limit/light_high_contrast.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...apshots/primer/alpha/text_field/with_character_limit_over_limit/dark_dimmed.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....ts-snapshots/primer/alpha/text_field/with_character_limit_over_limit/light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...primer/alpha/text_field/with_character_limit_over_limit/light_high_contrast.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...apshots/primer/open_project/border_box/collapsible_header/collapsed/default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...apshots/primer/open_project/border_box/collapsible_header/collapsed/focused.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...snapshots/primer/open_project/border_box/collapsible_header/default/default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...snapshots/primer/open_project/border_box/collapsible_header/default/focused.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pshots/primer/open_project/border_box/collapsible_header/with_count/default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pshots/primer/open_project/border_box/collapsible_header/with_count/focused.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../primer/open_project/border_box/collapsible_header/with_description/default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../primer/open_project/border_box/collapsible_header/with_description/focused.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion app/components/primer/open_project/border_box/collapsible_header.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
align-items: center;
column-gap: var(--stack-gap-normal);
row-gap: var(--base-size-4);
overflow: hidden;

.CollapsibleHeader > & {
flex: 1;
Expand Down Expand Up @@ -66,10 +67,12 @@
}

.CollapsibleHeader-title-line {
flex-basis: 66%;
display: flex;
align-items: center;
gap: var(--stack-gap-condensed);
min-width: fit-content;
overflow: hidden;
max-width: 100%;
Comment on lines 69 to +75
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.CollapsibleHeader-title-line { flex-basis: 66%; } is a hard-coded percentage that affects the flex item’s main size. Since the trigger area switches to flex-direction: column in the container query and in --multi-line mode, this flex-basis can become confusing and may behave inconsistently across browsers (percentage basis on an auto-sized column flex container). Consider replacing this with a more explicit/robust sizing approach (e.g., flex grow/shrink rules) or scoping the percentage sizing to only the row layout.

Copilot uses AI. Check for mistakes.
}

.CollapsibleHeader-description {
Expand Down
2 changes: 1 addition & 1 deletion app/components/primer/open_project/border_box/collapsible_header.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class CollapsibleHeader < Primer::Component
"Box-title"
)

Primer::Beta::Heading.new(tag: fetch_or_fallback(TITLE_TAG_OPTIONS, tag, TITLE_TAG_DEFAULT), **system_arguments)
Primer::Beta::Truncate.new(tag: fetch_or_fallback(TITLE_TAG_OPTIONS, tag, TITLE_TAG_DEFAULT), **system_arguments)
}

# Optional count
Expand Down