-
Notifications
You must be signed in to change notification settings - Fork 1
[72657] Improve responsiveness of Banner component #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@openproject/primer-view-components': patch | ||
| --- | ||
|
|
||
| Let Banner component react on container size instead of screen size |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| /* Banner alert */ | ||
| x-banner { | ||
| container-type: inline-size; | ||
| display: block; | ||
| } | ||
|
|
||
| .Banner { | ||
| position: relative; | ||
|
|
@@ -14,7 +18,7 @@ | |
| grid-template-rows: min-content; | ||
|
|
||
| /* `sm` breakpoint variation */ | ||
| @media (max-width: 543.98px) { | ||
| @container (max-width: 543.98px) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why a sub-pixel amount btw?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Primer CSS relies everywhere on pixel based breakpoints instead of variables.. I assume that they don't have access to those here, because they originate from another repo. 🤷
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, but this is subpixel.. |
||
| grid-template-areas: | ||
| 'visual message close' | ||
| '. actions actions'; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.