Skip to content

Conversation

@itsadityaaaaa
Copy link
Contributor

@itsadityaaaaa itsadityaaaaa commented Dec 15, 2025

Explanation

Essential Checklist

  • The PR title and explanation each start with "Fix [BUG]: Drawer menu higllights do not update on back navigation #6042 " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

  • Tablet
Tablet_demo.mp4
  • Mobile
mobile_demo.mp4
  • Affected Espresso Tests Result
Screenshot from 2025-12-28 21-45-52 Screenshot from 2025-12-28 21-44-13

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@itsadityaaaaa itsadityaaaaa requested a review from a team as a code owner December 15, 2025 15:52
@itsadityaaaaa
Copy link
Contributor Author

@adhiamboperes I think this CI failure appears unrelated to this PR.
Build is failing during Bazel dependency fetch before tests execute.
This looks like an CI/dependency issue.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itsadityaaaaa!

There are a few things to clarify/improve:

  1. Part of the PR description reads: "Removed dependency on menu ordering, preventing issues when menu structure changes." However, I see no code that points to this. Could you please elaborate?
  2. The NavigationDrawerFragment.kt is covered via NavigationDrawerActivityDebugTest and NavigationDrawerActivityProdTest. Please add tests for verifying the changes introduced. If you need support on a way forward, please let us know.
  3. The video demos show menu highlight for the options items, but it is important to show that this is fixed for the footer items as weel, i.e. the admin controls and developer options items.
  4. The PR title and the start of the explanation are missing a reference to "fix #issueNumber", which are used to automate closing the issue once the PR is merged. Please add these.

@itsadityaaaaa
Copy link
Contributor Author

@adhiamboperes Thank You! for your suggestions, will work on it and get back to you if need any help

@itsadityaaaaa itsadityaaaaa changed the title fix drawer highlight issue Fix #6042 Drawer highlight issue Dec 20, 2025
@itsadityaaaaa itsadityaaaaa marked this pull request as draft December 24, 2025 05:44
@itsadityaaaaa itsadityaaaaa marked this pull request as ready for review December 28, 2025 09:13
@itsadityaaaaa itsadityaaaaa marked this pull request as draft December 28, 2025 09:18
@github-actions
Copy link

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 0.00%
Coverage Analysis: PASS

Exempted coverage

Files exempted from coverage
File Exemption Reason
NavigationDrawerFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/drawer/NavigationDrawerFragmentPresenter.kt
This file is exempted from having a test file; skipping coverage check.
NavigationDrawerFragment.ktapp/src/main/java/org/oppia/android/app/drawer/NavigationDrawerFragment.kt
This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

@itsadityaaaaa itsadityaaaaa marked this pull request as ready for review December 28, 2025 11:04
@itsadityaaaaa
Copy link
Contributor Author

@adhiamboperes I did changes according to the suggestion, please review the modification and tell me any other modifications are required.

@itsadityaaaaa
Copy link
Contributor Author

@adhiamboperes Is there anything else I need to do on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Drawer menu higllights do not update on back navigation

2 participants