Skip to content

Fix #5989, #6053, #6059, #6060: Rebuild app & WorkManager initialization #6062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
BenHenning wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix #5989, #6053, #6059, #6060: Rebuild app & WorkManager initialization #6062

BenHenning wants to merge 1 commit into from

Conversation

@BenHenning
Copy link
Member

@BenHenning BenHenning commented Jan 2, 2026

Explanation

Fixes #5989
Fixes #6053
Fixes #6059 (probably)
Fixes #6060

TODO: Finish this PR description.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@BenHenning
Rebuild app & WorkManager initialization.
8f7d732 
This includes substantial changes to how the app starts up in all cases,
but especially for workers. The new approach is robust against worker
changes (including class renames or input changes), centralizes
intialization so that all workers always run in a sane environment, and
ensures all app initialization is done in a completely robust and safe
way.

Also, re-write much of the work manager wiki page to include new design
details and significant debugging recommendations.

Testing, code, and wiki documentation are not yet complete. This also
has only been tested on the developer build of the app, so more
validation will be necessary.
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Thanks for submitting this pull request! Some main reviewers have taken time off for the next few weeks, so it may take a little while before we can look at this PR. We appreciate your patience while some of our team members recharge. We'll be fully returning on 05 January 2026.

@BenHenning
Copy link
Member Author

BenHenning commented Jan 2, 2026

Note that this is probably in a good enough place for me to work off of it to make progress on #3506 (which was my original goal heading into this), and I'll need to circle back to this PR. It still needs a lot of documentation and testing work, including figuring out hopefully a better testing strategy than using fakes (I'm hoping it's possible to actually properly orchestrate kicking off the jobs but I have a lot more digging to do in order to figure that out fully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@BenHenning