Modifed Coding-style-guide.md by Helper2020 · Pull Request #474 · oppia/oppia-web-developer-docs

Helper2020 · 2025-10-12T00:25:31Z

No description provided.

Helper2020 · 2025-10-13T18:35:11Z

@seanlip PTAL @jayam04 PTAL

seanlip · 2025-10-19T14:45:08Z

@Helper2020 Adding my comments from chat:

Use backticks (`) for code snippets. Search for "markdown backticks" or similar for info.
Please check the backend code style guidance that is already on the page and drop anything that does not match black's style.

Helper2020 · 2025-10-20T22:45:32Z

@seanlip Sorry, I forgot to push the last commit.

@Helper2020 Adding my comments from chat:

Use backticks (`) for code snippets. Search for "markdown backticks" or similar for info.

Please check the backend code style guidance that is already on the page and drop anything that does not match black's style.

jayam04

LGTM!

jayam04 · 2025-10-22T15:02:42Z

@seanlip I didn't saw you are reviewing.

I added LGTM, but it requires you review, so I am not adding blocking review again.

@Helper2020 please ensure it's approved by @seanlip before merging.

seanlip

Thanks @Helper2020 -- just a couple of comments, PTAL.

seanlip · 2025-10-24T17:28:35Z

Coding-style-guide.md


 ## Python
+
+#### Black


Please move the section that talks about Black (basically, all the new stuff) just above the section that talks about Prettier, and give it the same level of heading. We should be consistent in how we describe the formatters.

seanlip · 2025-10-24T17:29:20Z

Coding-style-guide.md

-                                          'def',
-                                          None)
+  - **Indentation inside parentheses:**  
+    Let [Black](https://black.readthedocs.io/en/stable/) handle indentation and line breaks automatically.  


Have the Black hyperlink link to the section of this wiki page that discusses Black, instead.

Helper2020

@seanlip PTAL

Helper2020 · 2025-10-29T00:08:15Z

Coding-style-guide.md


 ## Python
+
+#### Black


Helper2020 · 2025-10-29T23:48:15Z

Coding-style-guide.md

-                                          'def',
-                                          None)
+  - **Indentation inside parentheses:**  
+    Let [Black](https://black.readthedocs.io/en/stable/) handle indentation and line breaks automatically.  


seanlip

@Helper2020 Just a couple more suggested changes, then it looks good to merge. Thanks!

seanlip · 2025-11-03T15:05:06Z

Coding-style-guide.md

+  - **Indentation inside parentheses:**  
+    Let [Black](#black) handle indentation and line breaks automatically.  
+    Do **not** manually align to the opening parenthesis or indent by a fixed number of spaces.  


Suggested change

- **Indentation inside parentheses:**

Let [Black](#black) handle indentation and line breaks automatically.

Do **not** manually align to the opening parenthesis or indent by a fixed number of spaces.

- Indentation inside parentheses: Let [Black](#black) handle indentation and line breaks automatically. Do **not** manually align to the opening parenthesis or indent by a fixed number of spaces.

seanlip · 2025-11-03T15:05:34Z

Coding-style-guide.md

+- **Manual formatting:** You can format a specific file manually using:
+  ```bash
+  black /home/dev/opensource/oppia/core/controllers/android.py


Suggested change

- **Manual formatting:** You can format a specific file manually using:

```bash

black /home/dev/opensource/oppia/core/controllers/android.py

- **Manual formatting:** You can format a specific file manually using `black {{filepath}}`. For example, to format android.py, you would run:

```bash

black /home/dev/opensource/oppia/core/controllers/android.py

@seanlip PTAL

seanlip

Thanks @Helper2020 !

Helper2020 added 2 commits October 11, 2025 20:24

Modifed Coding-style-guide.md

c5a3b47

Added and moved text around

509277a

Helper2020 marked this pull request as ready for review October 13, 2025 18:31

jayam04 approved these changes Oct 22, 2025

View reviewed changes

seanlip requested changes Oct 24, 2025

View reviewed changes

seanlip assigned Helper2020 Oct 24, 2025

Addressed comments

8bd877f

Helper2020 commented Oct 29, 2025

View reviewed changes

seanlip requested changes Nov 3, 2025

View reviewed changes

Addressed comments

cddb158

seanlip approved these changes Nov 5, 2025

View reviewed changes

seanlip merged commit 853c72d into oppia:develop Nov 5, 2025
3 checks passed

Conversation

Helper2020 commented Oct 12, 2025

Uh oh!

Helper2020 commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanlip commented Oct 19, 2025

Uh oh!

Helper2020 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayam04 left a comment

Choose a reason for hiding this comment

Uh oh!

jayam04 commented Oct 22, 2025

Uh oh!

seanlip left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Helper2020 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanlip left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanlip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Helper2020 commented Oct 13, 2025 •

edited

Loading

Helper2020 commented Oct 20, 2025 •

edited

Loading