Skip to content

Conversation

@gmazoyer
Copy link
Contributor

@gmazoyer gmazoyer commented Oct 31, 2024

Fixes #27

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/node.py 88.88% 1 Missing ⚠️
@@             Coverage Diff             @@
##           develop     #118      +/-   ##
===========================================
+ Coverage    64.41%   64.42%   +0.01%     
===========================================
  Files           75       75              
  Lines         6879     6882       +3     
  Branches      1362     1363       +1     
===========================================
+ Hits          4431     4434       +3     
  Misses        2095     2095              
  Partials       353      353              
Flag Coverage Δ
python-3.10 43.43% <66.66%> (+0.02%) ⬆️
python-3.11 43.43% <66.66%> (+0.02%) ⬆️
python-3.12 43.43% <66.66%> (+0.02%) ⬆️
python-3.9 43.37% <66.66%> (+0.02%) ⬆️
python-filler-3.12 23.85% <22.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/node.py 68.51% <88.88%> (+0.09%) ⬆️

@gmazoyer gmazoyer added the type/bug Something isn't working as expected label Oct 31, 2024
@gmazoyer gmazoyer marked this pull request as ready for review October 31, 2024 14:59
@gmazoyer gmazoyer requested a review from a team October 31, 2024 14:59
@gmazoyer gmazoyer merged commit 65bd9a3 into develop Nov 4, 2024
12 checks passed
@gmazoyer gmazoyer deleted the gma-20241031-27 branch November 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: SDK improvements to working with resource pools

3 participants