Skip to content

When using only the values of a dict use the values() method #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024
Merged

When using only the values of a dict use the values() method #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infrahub_sdk/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def _get(self, key: str, kind: Optional[Union[str, type[SchemaType]]] = None, ra
if kind_name and kind_name in self._store and key in self._store[kind_name]: # type: ignore[attr-defined]
return self._store[kind_name][key] # type: ignore[attr-defined]

for _, item in self._store.items(): # type: ignore[attr-defined]
for item in self._store.values(): # type: ignore[attr-defined]
if key in item:
return item[key]

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ ignore = [
"FURB177", # Prefer `Path.cwd()` over `Path().resolve()` for current-directory lookups
"N802", # Function name should be lowercase
"N806", # Variable in function should be lowercase
"PERF102", # When using only the values of a dict use the `values()` method
"PERF203", # `try`-`except` within a loop incurs performance overhead
"PERF401", # Use a list comprehension to create a transformed list
"PLC0206", # Extracting value from dictionary without calling `.items()`
Expand Down