Move test from integration -> unit #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenstad
force-pushed
the
pog-relocate-test
branch
from
86d9af5 to
c224ec3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #123 +/- ##
===========================================
+ Coverage 64.34% 65.38% +1.04%
===========================================
Files 75 75
Lines 6893 6893
Branches 1365 1365
===========================================
+ Hits 4435 4507 +72
+ Misses 2103 2020 -83
- Partials 355 366 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
ogenstad
force-pushed
the
pog-relocate-test
branch
from
c224ec3 to
1a5c817
Compare
dgarros
approved these changes
Nov 2, 2024
tests/unit/ctl/test_transform_app.py
Outdated
| assert output.exit_code == 1 | ||
|
|
||
| @staticmethod | ||
| @pytest.mark.xfail(reason="Seems problematic in Python 3.9") |
There was a problem hiding this comment.
we could use skipif here to exclude these tests in 3.9 but keep them for the other version of Python
https://docs.pytest.org/en/stable/how-to/skipping.html#id1
There was a problem hiding this comment.
Ah yes good call, updated to do this instead.
ogenstad
force-pushed
the
pog-relocate-test
branch
from
1a5c817 to
392ef37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added after the repo was split and shouldn't be in the integration folder as we're only mocking the data. Also given the config of the conftest fixtures that gets automatically loaded it wouldn't work as written as part of the integration tests when we re-enable them.
Also moved the utils into the helpers directory.
I've also marked four of the tests as ok to fail, this wasn't noticed earlier but looks to be related to Python 3.9. I still think it's better to have it in this state to ease the reactivation of integration tests where these tests previously didn't exist.