-
Notifications
You must be signed in to change notification settings - Fork 6
sets branch on InfrahubClient when running infrahubctl transform infahubctl check and infrahubctl generator
#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sets branch on InfrahubClient when running infrahubctl transform infahubctl check and infrahubctl generator
#134
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## stable #134 +/- ##
=======================================
Coverage 64.34% 64.34%
=======================================
Files 75 75
Lines 6893 6893
Branches 1365 1365
=======================================
Hits 4435 4435
Misses 2103 2103
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would be good to add a newsfragment to include it in the release note
0ab85fa to
fa3f84d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're sending the branch when initializing the transport class a bit further down.
I'd imagine that some parts work now but that it might load the schema from the wrong branch etc without this fix. Looks like we might have the same issue for Checks and Generators just base on how the client is initialized.
transform = get_transform_class_instance(
transform_config=transform_config,
branch=branch,
client=client,
)infrahubctl transforminfrahubctl transform infahubctl check and infrahubctl generator
eba6f2f to
799405c
Compare
fixes #133
additionally fixes the same issue for
infrahubctl checkandinfrahubctl generatorcommands.