Skip to content

Return a proper error message when executing schema load with the wrong credential #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Return a proper error message when executing schema load with the wrong credential #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/127.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CTL: `schema load` return a proper error message when authentication is missing or when the user doesn't have the permission to update the schema.
10 changes: 6 additions & 4 deletions infrahub_sdk/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,10 +539,12 @@ def _validate_load_schema_response(response: httpx.Response) -> SchemaLoadRespon
status = response.json()
return SchemaLoadResponse(hash=status["hash"], previous_hash=status["previous_hash"])

if response.status_code == httpx.codes.BAD_REQUEST:
return SchemaLoadResponse(errors=response.json())

if response.status_code == httpx.codes.UNPROCESSABLE_ENTITY:
if response.status_code in [
httpx.codes.BAD_REQUEST,
httpx.codes.UNPROCESSABLE_ENTITY,
httpx.codes.UNAUTHORIZED,
httpx.codes.FORBIDDEN,
]:
return SchemaLoadResponse(errors=response.json())

response.raise_for_status()
Expand Down