fix: build for python 3.13#287
Merged
fatih-acar merged 1 commit intoinfrahub-developfrom Feb 28, 2025
Merged
Conversation
Signed-off-by: Fatih Acar <fatih@opsmill.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## infrahub-develop #287 +/- ##
=================================================
Coverage 70.53% 70.53%
=================================================
Files 81 81
Lines 7561 7561
Branches 1469 1469
=================================================
Hits 5333 5333
Misses 1849 1849
Partials 379 379
Flags with carried forward coverage won't be shown. Click here to find out more. |
dgarros
approved these changes
Feb 28, 2025
ogenstad
approved these changes
Feb 28, 2025
Contributor
ogenstad
left a comment
ogenstad
left a comment
There was a problem hiding this comment.
LGTM, but based on that screenshot it seems like we also need to end with a test that validates that the running Python version is the one that we expect. :/ Without that I don't see how we could trust these tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#256 was supposed to reintroduce 3.13 support, but according to CI logs:
Edit: need to investigate why
poetry installis 20x slower with 3.13...