Raise URLNotFoundError instead of infinite retry#288
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## stable #288 +/- ##
==========================================
+ Coverage 70.35% 70.38% +0.02%
==========================================
Files 81 81
Lines 7510 7522 +12
Branches 1465 1467 +2
==========================================
+ Hits 5284 5294 +10
- Misses 1842 1844 +2
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8028a02 to
3f0b603
Compare
3f0b603 to
de43a7b
Compare
ajtmccarty
approved these changes
Feb 28, 2025
dgarros
reviewed
Feb 28, 2025
Contributor
dgarros
left a comment
There was a problem hiding this comment.
so today we're retry indefinitely ?
|
|
||
| @task(name="generate-sdk") | ||
| def generate_python_sdk(context: Context) -> None: | ||
| def generate_python_sdk(context: Context) -> None: # noqa: ARG001 |
Contributor
There was a problem hiding this comment.
you can remove context if we don't use it
Contributor
Author
There was a problem hiding this comment.
It seems to be required by invoke tasks
Contributor
Author
If we delete a branch while a task in running on this branch and triggers this path, typically |
dgarros
approved these changes
Mar 4, 2025
9b7ff87 to
fd67def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5800.