Set default value of populate_store argument on client query methods to True #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #302 +/- ##
===========================================
+ Coverage 70.38% 70.44% +0.06%
===========================================
Files 81 81
Lines 7522 7522
Branches 1467 1467
===========================================
+ Hits 5294 5299 +5
+ Misses 1844 1840 -4
+ Partials 384 383 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
github-actions
bot
added
type/documentation
Objects retrieved by the SDK will be stored by the internal client store by default. The behavior can be changed by setting it explicitly to False. This removes the need to set populate_store to True when you want to prefetch relationships.
wvandeun
force-pushed
the
wvd-fix-prefetch-relationships
branch
from
239cdef to
90d211a
Compare
wvandeun
removed
the
type/documentation
wvandeun
changed the title
dgarros
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15
client will now by default store all the objects it retrieved using the query methods in the internal store. This can be disabled by setting populate_store argument to False. This rermoves the need to set populate_store to True when you want to use prefetch_relationships to retrieve related nodes for included relationships.