fix(testing): remove version fixture #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #344 +/- ##
===========================================
- Coverage 73.83% 73.81% -0.03%
===========================================
Files 92 92
Lines 8486 8485 -1
Branches 1657 1657
===========================================
- Hits 6266 6263 -3
- Misses 1787 1789 +2
Partials 433 433
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
2 times, most recently
from
3fae22f to
c11287b
Compare
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
3 times, most recently
from
1de099f to
7dc8e86
Compare
dgarros
approved these changes
Apr 13, 2025
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
from
7dc8e86 to
fc8ec3e
Compare
Deploying infrahub-sdk-python with
|
| Latest commit: |
b8c4f9c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9f31937.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://fac-fix-testcontainer-ver.infrahub-sdk-python.pages.dev |
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
from
fc8ec3e to
9ef7028
Compare
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
from
1c86fc8 to
7284a4f
Compare
|
@dgarros I had to drop python 3.9 support, not sure if this was expected... |
dgarros
reviewed
Apr 15, 2025
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
from
7284a4f to
0dc979d
Compare
Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
fatih-acar
force-pushed
the
fac-fix-testcontainer-ver
branch
from
0dc979d to
b8c4f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this hardcoded fixture, otherwise using the
TestInfrahubDockerClientclass will use thelatestInfrahub tag unless the environment variable is set. We want to use the version from the infrahub-testcontainers in that case and not fallback tolatest.Related to opsmill/infrahub#6235