Skip to content

Conversation

@wvandeun
Copy link
Contributor

  • get and set the hfid for related nodes of cardinality many relationships
  • add hfid support to RelationshipManager's add/extend/remove methods

@wvandeun wvandeun self-assigned this Apr 22, 2025
@wvandeun wvandeun force-pushed the wvd-hfid-card-many branch from 68a5fcf to 8a5cb3b Compare April 22, 2025 12:32
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 22, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d2110a
Status: ✅  Deploy successful!
Preview URL: https://66b7de68.infrahub-sdk-python.pages.dev
Branch Preview URL: https://wvd-hfid-card-many.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/node.py 14.28% 10 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##           stable     #370      +/-   ##
==========================================
- Coverage   73.91%   73.80%   -0.11%     
==========================================
  Files          92       92              
  Lines        8536     8548      +12     
  Branches     1676     1680       +4     
==========================================
  Hits         6309     6309              
- Misses       1781     1793      +12     
  Partials      446      446              
Flag Coverage Δ
integration-tests 25.39% <0.00%> (-0.04%) ⬇️
python-3.10 47.29% <14.28%> (-0.05%) ⬇️
python-3.11 47.29% <14.28%> (-0.07%) ⬇️
python-3.12 47.27% <14.28%> (-0.09%) ⬇️
python-3.13 47.29% <14.28%> (-0.07%) ⬇️
python-3.9 45.68% <14.28%> (-0.09%) ⬇️
python-filler-3.12 24.22% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/node.py 77.57% <14.28%> (-0.86%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wvandeun wvandeun marked this pull request as ready for review April 22, 2025 12:53
@wvandeun wvandeun requested a review from a team April 23, 2025 14:06
@wvandeun wvandeun merged commit 565f729 into stable Apr 24, 2025
19 checks passed
@wvandeun wvandeun deleted the wvd-hfid-card-many branch April 24, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants