Skip to content

Conversation

@ogenstad
Copy link
Contributor

This is a small cleanup step for #281, where we clean up the cloning of the client within the generator.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9249a6f
Status: ✅  Deploy successful!
Preview URL: https://0f7fe084.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-client-clone-branch-para.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/generator.py 0.00% 1 Missing ⚠️
@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
+ Coverage    73.91%   73.94%   +0.03%     
===========================================
  Files           92       92              
  Lines         8536     8540       +4     
  Branches      1676     1676              
===========================================
+ Hits          6309     6315       +6     
+ Misses        1781     1779       -2     
  Partials       446      446              
Flag Coverage Δ
integration-tests 25.42% <0.00%> (-0.02%) ⬇️
python-3.10 47.36% <54.54%> (+0.02%) ⬆️
python-3.11 47.38% <54.54%> (+0.02%) ⬆️
python-3.12 47.36% <54.54%> (+<0.01%) ⬆️
python-3.13 47.38% <54.54%> (+0.02%) ⬆️
python-3.9 45.80% <54.54%> (+0.02%) ⬆️
python-filler-3.12 24.27% <36.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 68.04% <100.00%> (+0.14%) ⬆️
infrahub_sdk/recorder.py 70.00% <100.00%> (+1.57%) ⬆️
infrahub_sdk/generator.py 35.89% <0.00%> (+0.89%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad requested a review from a team April 23, 2025 08:11
@ogenstad ogenstad merged commit 23d9f1a into develop Apr 24, 2025
18 checks passed
@ogenstad ogenstad deleted the pog-client-clone-branch-param-IFC-1169 branch April 24, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants