Skip to content

Remove local validation of query filters when calling client.filters() #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove local validation of query filters when calling client.filters() #41

merged 1 commit into from
Sep 23, 2024

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Sep 21, 2024

Fixes #9 #10 #30

Remove the local validation of the query filters when calling client.filters()

I completely removed the code since the filters will be removed from infrahub in the next version

@dgarros dgarros added the type/feature New feature or request label Sep 21, 2024
@dgarros dgarros requested review from a team September 21, 2024 12:53
ogenstad
ogenstad approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also delete the FilterNotFoundError exception entirely from the exceptions file?

@dgarros dgarros force-pushed the dga-20240921-remove-filters branch from 2a53bfb to ca53b9a Compare September 23, 2024 08:39
@dgarros
Copy link
Contributor Author

dgarros commented Sep 23, 2024

LGTM, can we also delete the FilterNotFoundError exception entirely from the exceptions file?

Good point, I removed FilterNotFoundError completely

@dgarros dgarros merged commit 37e382a into develop Sep 23, 2024
10 checks passed
@dgarros dgarros deleted the dga-20240921-remove-filters branch September 23, 2024 08:58
@dgarros dgarros mentioned this pull request Oct 4, 2024
Merged
@dgarros dgarros mentioned this pull request Oct 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogenstad ogenstad ogenstad approved these changes

@wvandeun wvandeun wvandeun approved these changes

Assignees

No one assigned

Labels

type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: Remove the local validation of the query filters when calling client.filters()

4 participants

@dgarros @ogenstad @wvandeun