utils.py: update file not found exception message #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous message implies the file is found but the contents are not valid. Especially when referring to a YAML file. This adds a clearer message and specifies where the code has looked for the file.
Clearer argument name and use of path object
Downstream method changed signature: file_name --> file_path
Fix test_missing_file after error message change
Use correct variable name
Update incorrect encoding test after read_file method changes.
ajtmccarty
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous message implies the file is found but the contents are not valid. Especially when referring to a YAML file.
This adds a clearer message and specifies where the code has looked for the file.
Example: