Skip to content

Conversation

@ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Jun 26, 2025

fixes #452

we accidentally included a breaking change in version 1.13.1. we stopped allowing passing a RelatedNode as an input when creating a new InfrahubNode. This PR makes that possible again

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 26, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59dd8e0
Status: ✅  Deploy successful!
Preview URL: https://b7102cf0.infrahub-sdk-python.pages.dev
Branch Preview URL: https://ajtm-06262025-sdk-related-no.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/node/node.py 78.94% 2 Missing and 2 partials ⚠️
@@           Coverage Diff           @@
##           stable     #453   +/-   ##
=======================================
  Coverage   75.57%   75.58%           
=======================================
  Files         100      100           
  Lines        8751     8769   +18     
  Branches     1704     1712    +8     
=======================================
+ Hits         6614     6628   +14     
- Misses       1661     1665    +4     
  Partials      476      476           
Flag Coverage Δ
integration-tests 34.62% <26.31%> (-0.02%) ⬇️
python-3.10 47.90% <73.68%> (+0.03%) ⬆️
python-3.11 47.90% <73.68%> (+0.03%) ⬆️
python-3.12 47.90% <73.68%> (+0.06%) ⬆️
python-3.13 47.90% <73.68%> (+0.06%) ⬆️
python-3.9 46.57% <73.68%> (+0.06%) ⬆️
python-filler-3.12 25.23% <5.26%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/node/node.py 75.19% <78.94%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ajtmccarty ajtmccarty marked this pull request as ready for review June 26, 2025 20:27
@ajtmccarty ajtmccarty requested a review from a team June 26, 2025 20:27
@ajtmccarty ajtmccarty merged commit 62dabad into stable Jun 26, 2025
19 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-06262025-sdk-related-node-fix branch June 26, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: SDK 1.13.1 and Infrahub 1.3.0 Unable to create objects with relationships

3 participants