Skip to content

Conversation

@FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Jun 27, 2025

Fixes #455

  • We set the __typename when relationships are already a RelatedNode as we were omitting it previously so it could not do the lookup of the object in the store.
  • also sets kind and display_label for the peer if it exists on the input RelatedNode

… relationships that are already a RelatedNode
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##           stable     #456      +/-   ##
==========================================
+ Coverage   75.58%   75.62%   +0.04%     
==========================================
  Files         100      100              
  Lines        8769     8767       -2     
  Branches     1712     1712              
==========================================
+ Hits         6628     6630       +2     
+ Misses       1663     1661       -2     
+ Partials      478      476       -2     
Flag Coverage Δ
integration-tests 34.65% <37.50%> (+0.03%) ⬆️
python-3.10 47.86% <50.00%> (-0.07%) ⬇️
python-3.11 47.88% <50.00%> (-0.05%) ⬇️
python-3.12 47.83% <50.00%> (-0.07%) ⬇️
python-3.13 47.86% <50.00%> (-0.05%) ⬇️
python-3.9 46.55% <50.00%> (-0.05%) ⬇️
python-filler-3.12 25.26% <25.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/node/node.py 74.93% <100.00%> (-0.26%) ⬇️
infrahub_sdk/node/related_node.py 90.25% <100.00%> (+3.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 27, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 636a756
Status: ✅  Deploy successful!
Preview URL: https://fbe6ebf6.infrahub-sdk-python.pages.dev
Branch Preview URL: https://may-202506-node-add-typename.infrahub-sdk-python.pages.dev

View logs

@ajtmccarty ajtmccarty changed the title Add setting typename if it exists when calling _init_relationships Add setting typename, display_label, and kind if it exists when calling _init_relationships Jun 27, 2025
@ajtmccarty ajtmccarty requested a review from a team June 27, 2025 21:26
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can either of you add a changelog before merging this PR

@ajtmccarty ajtmccarty merged commit 1d78e57 into stable Jun 30, 2025
19 checks passed
@ajtmccarty ajtmccarty deleted the may-202506-node-add-typename branch June 30, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Error when accessing RelatedNode on a created device missing fields to query it

3 participants