Fix load_from_disk method to support folder with multiple file extensions
#463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaptisteGi
changed the title
load_from_disk method to load folder with multiple file extensions
BaptisteGi
changed the title
load_from_disk method to load folder with multiple file extensionsload_from_disk method to support folder with multiple file extensions
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #463 +/- ##
==========================================
+ Coverage 75.62% 75.64% +0.01%
==========================================
Files 100 100
Lines 8767 8769 +2
Branches 1712 1714 +2
==========================================
+ Hits 6630 6633 +3
+ Misses 1663 1660 -3
- Partials 474 476 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
BaptisteGi
commented
Jul 3, 2025
| @classmethod | ||
| def load_from_disk(cls, paths: list[Path]) -> list[Self]: | ||
| yaml_files: list[Self] = [] | ||
| file_extensions = {".yaml", ".yml", ".json"} # FIXME: .json is not a YAML file, should be removed |
There was a problem hiding this comment.
@LucasG0 do you know why we have .json here? too afraid about side effect of removing it from here
dgarros
approved these changes
Jul 3, 2025
Deploying infrahub-sdk-python with
|
| Latest commit: |
8031518
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df436a59.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://bgi-fix-yaml-file-462.infrahub-sdk-python.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines the
load_from_diskmethod ininfrahub_sdk/yaml.pyto make sure we can load folders that contain various file types.Relates to #462