Skip to content

Fixes #469 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Fixes #469 #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/469.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes ignored node variable in filters()
8 changes: 3 additions & 5 deletions infrahub_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,6 @@ async def filters(
if at:
at = Timestamp(at)

node = InfrahubNode(client=self, schema=schema, branch=branch)
filters = kwargs
pagination_size = self.pagination_size

Expand Down Expand Up @@ -830,7 +829,7 @@ async def process_batch() -> tuple[list[InfrahubNode], list[InfrahubNode]]:

for page_number in range(1, total_pages + 1):
page_offset = (page_number - 1) * pagination_size
batch_process.add(task=process_page, node=node, page_offset=page_offset, page_number=page_number)
batch_process.add(task=process_page, page_offset=page_offset, page_number=page_number)

async for _, response in batch_process.execute():
nodes.extend(response[1]["nodes"])
Expand All @@ -847,7 +846,7 @@ async def process_non_batch() -> tuple[list[InfrahubNode], list[InfrahubNode]]:

while has_remaining_items:
page_offset = (page_number - 1) * pagination_size
response, process_result = await process_page(page_offset, page_number)
response, process_result = await process_page(page_offset=page_offset, page_number=page_number)

nodes.extend(process_result["nodes"])
related_nodes.extend(process_result["related_nodes"])
Expand Down Expand Up @@ -1949,7 +1948,6 @@ def filters(
if at:
at = Timestamp(at)

node = InfrahubNodeSync(client=self, schema=schema, branch=branch)
filters = kwargs
pagination_size = self.pagination_size

Expand Down Expand Up @@ -1996,7 +1994,7 @@ def process_batch() -> tuple[list[InfrahubNodeSync], list[InfrahubNodeSync]]:

for page_number in range(1, total_pages + 1):
page_offset = (page_number - 1) * pagination_size
batch_process.add(task=process_page, node=node, page_offset=page_offset, page_number=page_number)
batch_process.add(task=process_page, page_offset=page_offset, page_number=page_number)

for _, response in batch_process.execute():
nodes.extend(response[1]["nodes"])
Expand Down