Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Jul 22, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Corrected relationship processing during node retrieval with the Sync Client when prefetching related nodes.
    • Schema loading now properly ignores non-YAML files in folders.
    • Fixed an issue with the ignored node variable in filters.
    • Improved handling of parallel execution with filters for the Infrahub Client Sync.
    • Prevented sending empty schema lists to Infrahub when no valid schemas are found.
  • Chores

    • Updated version to 1.13.4.
    • Updated changelog with latest release notes.

@dgarros dgarros requested a review from a team July 22, 2025 20:10
@coderabbitai
Copy link

coderabbitai bot commented Jul 22, 2025

Walkthrough

The changes update the project for the 1.13.4 release by adding a new entry to the main changelog, deleting several individual changelog fragment files, and incrementing the version number in the project configuration. No source code or public API changes are present.

Changes

Files/Groups Change Summary
CHANGELOG.md Added release entry for version 1.13.4 with a summary of included fixes.
changelog/461.fixed.md
changelog/462.fixed.md
changelog/469.fixed.md
changelog/fixed.md
Deleted changelog fragment files describing individual fixes now consolidated in the main changelog.
pyproject.toml Updated version number from 1.13.3 to 1.13.4.

Estimated code review effort

1 (~2 minutes)


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 396c50b
Status: ✅  Deploy successful!
Preview URL: https://c0157b5e.infrahub-sdk-python.pages.dev
Branch Preview URL: https://dga-release-1-13-4.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (19a03ae) and HEAD (396c50b). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (19a03ae) HEAD (396c50b)
python-3.10 2 1
python-3.9 2 1
python-3.11 2 1
python-3.12 2 1
python-filler-3.12 2 1
python-3.13 2 1
integration-tests 2 0
@@            Coverage Diff             @@
##           stable     #477      +/-   ##
==========================================
- Coverage   75.74%   69.84%   -5.91%     
==========================================
  Files         100      100              
  Lines        8841     8792      -49     
  Branches     1736     1723      -13     
==========================================
- Hits         6697     6141     -556     
- Misses       1665     2167     +502     
- Partials      479      484       +5     
Flag Coverage Δ
integration-tests ?
python-3.10 47.94% <ø> (-0.25%) ⬇️
python-3.11 47.96% <ø> (-0.23%) ⬇️
python-3.12 47.91% <ø> (-0.27%) ⬇️
python-3.13 47.94% <ø> (-0.23%) ⬇️
python-3.9 46.62% <ø> (-0.18%) ⬇️
python-filler-3.12 25.21% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

18-23: Fix several typos in the 1.13.4 release notes

- Fix processing of relationshhip during nodes retrieval using the Sync Client, when prefecthing related_nodes. ([#461](https://github.com/opsmill/infrahub-sdk-python/issues/461))
+ Fix processing of relationship during node retrieval using the Sync Client when prefetching `related_nodes`. ([#461](https://github.com/opsmill/infrahub-sdk-python/issues/461))

- Avoid sending empty list to infrahub if no valids schemas are found.
+ Avoid sending an empty schema list to Infrahub when no valid schemas are found.

This removes spelling errors (“relationshhip”, “prefecthing”, “valids”) and tightens wording.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19a03ae and 396c50b.

📒 Files selected for processing (6)
  • CHANGELOG.md (1 hunks)
  • changelog/461.fixed.md (0 hunks)
  • changelog/462.fixed.md (0 hunks)
  • changelog/469.fixed.md (0 hunks)
  • changelog/fixed.md (0 hunks)
  • pyproject.toml (1 hunks)
🪛 LanguageTool
CHANGELOG.md

[grammar] ~18-~18: Ensure spelling is correct
Context: ...5-07-22 ### Fixed - Fix processing of relationshhip during nodes retrieval using the Sync C...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[grammar] ~18-~18: Ensure spelling is correct
Context: ...s retrieval using the Sync Client, when prefecthing related_nodes. ([#461](https://github.c...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

💤 Files with no reviewable changes (4)
  • changelog/469.fixed.md
  • changelog/461.fixed.md
  • changelog/462.fixed.md
  • changelog/fixed.md
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[grammar] ~18-~18: Ensure spelling is correct
Context: ...5-07-22 ### Fixed - Fix processing of relationshhip during nodes retrieval using the Sync C...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[grammar] ~18-~18: Ensure spelling is correct
Context: ...s retrieval using the Sync Client, when prefecthing related_nodes. ([#461](https://github.c...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🔇 Additional comments (1)
pyproject.toml (1)

3-3: No leftover old version strings found

  • The package’s __version__ is dynamically loaded via importlib.metadata in infrahub_sdk/__init__.py, so no manual changes are needed there.
  • Ripgrep confirms no occurrences of "1.13.3" remain.
  • Literal version strings in tests (e.g. "1.1.0") are mocks for API responses and aren’t tied to the library bump.

LGTM.

@dgarros dgarros merged commit 5246e3f into stable Jul 22, 2025
20 checks passed
@dgarros dgarros deleted the dga-release-1.13.4 branch July 22, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants