-
Couldn't load subscription status.
- Fork 6
Prepare version 1.13.4 #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the project for the 1.13.4 release by adding a new entry to the main changelog, deleting several individual changelog fragment files, and incrementing the version number in the project configuration. No source code or public API changes are present. Changes
Estimated code review effort1 (~2 minutes) 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying infrahub-sdk-python with
|
| Latest commit: |
396c50b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0157b5e.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://dga-release-1-13-4.infrahub-sdk-python.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## stable #477 +/- ##
==========================================
- Coverage 75.74% 69.84% -5.91%
==========================================
Files 100 100
Lines 8841 8792 -49
Branches 1736 1723 -13
==========================================
- Hits 6697 6141 -556
- Misses 1665 2167 +502
- Partials 479 484 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
18-23: Fix several typos in the 1.13.4 release notes- Fix processing of relationshhip during nodes retrieval using the Sync Client, when prefecthing related_nodes. ([#461](https://github.com/opsmill/infrahub-sdk-python/issues/461)) + Fix processing of relationship during node retrieval using the Sync Client when prefetching `related_nodes`. ([#461](https://github.com/opsmill/infrahub-sdk-python/issues/461)) - Avoid sending empty list to infrahub if no valids schemas are found. + Avoid sending an empty schema list to Infrahub when no valid schemas are found.This removes spelling errors (“relationshhip”, “prefecthing”, “valids”) and tightens wording.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
CHANGELOG.md(1 hunks)changelog/461.fixed.md(0 hunks)changelog/462.fixed.md(0 hunks)changelog/469.fixed.md(0 hunks)changelog/fixed.md(0 hunks)pyproject.toml(1 hunks)
🪛 LanguageTool
CHANGELOG.md
[grammar] ~18-~18: Ensure spelling is correct
Context: ...5-07-22 ### Fixed - Fix processing of relationshhip during nodes retrieval using the Sync C...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~18-~18: Ensure spelling is correct
Context: ...s retrieval using the Sync Client, when prefecthing related_nodes. ([#461](https://github.c...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
💤 Files with no reviewable changes (4)
- changelog/469.fixed.md
- changelog/461.fixed.md
- changelog/462.fixed.md
- changelog/fixed.md
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[grammar] ~18-~18: Ensure spelling is correct
Context: ...5-07-22 ### Fixed - Fix processing of relationshhip during nodes retrieval using the Sync C...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~18-~18: Ensure spelling is correct
Context: ...s retrieval using the Sync Client, when prefecthing related_nodes. ([#461](https://github.c...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🔇 Additional comments (1)
pyproject.toml (1)
3-3: No leftover old version strings found
- The package’s
__version__is dynamically loaded viaimportlib.metadataininfrahub_sdk/__init__.py, so no manual changes are needed there.- Ripgrep confirms no occurrences of
"1.13.3"remain.- Literal version strings in tests (e.g.
"1.1.0") are mocks for API responses and aren’t tied to the library bump.LGTM.
Summary by CodeRabbit
Bug Fixes
Chores