Skip to content

respect ordering of files when loading #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

respect ordering of files when loading #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions infrahub_sdk/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ def load_from_disk(cls, paths: list[Path]) -> list[Self]:
yaml_files: list[Self] = []
file_extensions = {".yaml", ".yml", ".json"} # FIXME: .json is not a YAML file, should be removed

paths = sorted(paths, key=lambda p: p.name) # Ensure order when processing paths

for file_path in paths:
if not file_path.exists():
# Check if the provided path exists, relevant for the first call coming from the user
Expand All @@ -135,6 +133,7 @@ def load_from_disk(cls, paths: list[Path]) -> list[Self]:
elif file_path.is_dir():
# Introduce recursion to handle sub-folders
sub_paths = [Path(sub_file_path) for sub_file_path in file_path.glob("*")]
sub_paths = sorted(sub_paths, key=lambda p: p.name)
yaml_files.extend(cls.load_from_disk(paths=sub_paths))
# else: skip non-file, non-dir (e.g., symlink...)

Expand Down