-
Couldn't load subscription status.
- Fork 6
Prepare release 1.13.5 #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce a new changelog entry for version 1.13.5, documenting a fix related to respecting file ordering during directory loads. Additionally, the package version in the configuration file is incremented from 1.13.4 to 1.13.5. No other modifications are present. Changes
Estimated code review effort1 (~2 minutes) 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
14-18: Add cross-reference to the fixing PR/issue for traceability.Consider appending the PR or issue number that introduced the ordering fix, e.g.:
- Respect ordering when loading files from a directory ([#XYZ](…))This keeps the changelog uniformly actionable and searchable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)
3-3: Confirm the version bump propagates everywhere it’s consumed.
poetry versiononly updatespyproject.toml; many projects also expose the version at runtime (infrahub_sdk.__init__.__version__,__about__.py, etc.) or in CI release scripts.
Please double-check those spots so thatimport infrahub_sdk; infrahub_sdk.__version__returns1.13.5, and ensure a matching Git tag will be created.
Deploying infrahub-sdk-python with
|
| Latest commit: |
142df70
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c4495fd.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://dga-release-1-13-5.infrahub-sdk-python.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## stable #480 +/- ##
==========================================
- Coverage 75.74% 75.65% -0.09%
==========================================
Files 100 100
Lines 8841 8792 -49
Branches 1736 1723 -13
==========================================
- Hits 6697 6652 -45
+ Misses 1665 1662 -3
+ Partials 479 478 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary by CodeRabbit