-
Notifications
You must be signed in to change notification settings - Fork 6
Use correct case for Infrahub #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughCapitalization updates in comments and docstrings from “infrahub” to “Infrahub” across SDK, testing utilities, and an integration test. No functional, behavioral, or interface changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying infrahub-sdk-python with
|
| Latest commit: |
8273796
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f233e2e5.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-infrahub-case.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #498 +/- ##
===========================================
- Coverage 76.25% 75.74% -0.52%
===========================================
Files 100 100
Lines 9036 8846 -190
Branches 1732 1732
===========================================
- Hits 6890 6700 -190
Misses 1670 1670
Partials 476 476
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
infrahub_sdk/testing/docker.py (1)
16-17: Docstring capitalization fix looks good; consider aligning nearby comments too"Infrahub" is now correctly capitalized in the docstring. To keep consistency with the PR’s objective, consider updating the lowercase "infrahub" occurrences in the nearby comments within the InvalidVersion except block (Lines 25–27).
infrahub_sdk/schema/repository.py (1)
27-27: Tiny grammar tweak in docstringConsider pluralizing “purpose” to “purposes” for natural phrasing.
- """Class to regroup all elements of the Infrahub configuration for a repository for typing purpose.""" + """Class to regroup all elements of the Infrahub configuration for a repository for typing purposes."""
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
infrahub_sdk/pytest_plugin/items/graphql_query.py(1 hunks)infrahub_sdk/schema/repository.py(1 hunks)infrahub_sdk/testing/docker.py(1 hunks)tests/integration/test_infrahub_client.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: unit-tests (3.11)
- GitHub Check: unit-tests (3.9)
- GitHub Check: unit-tests (3.13)
- GitHub Check: unit-tests (3.12)
- GitHub Check: unit-tests (3.10)
- GitHub Check: integration-tests-latest-infrahub
🔇 Additional comments (2)
infrahub_sdk/pytest_plugin/items/graphql_query.py (1)
19-20: Comment capitalization is consistent with brandingComment reads well and aligns with the PR goal. No further changes needed.
tests/integration/test_infrahub_client.py (1)
68-71: Consistent capitalization in test commentsUpdated “Infrahub” capitalization matches the branding and keeps comments consistent. LGTM.
This is mostly to get rid of annoying warnings in my editor..
Summary by CodeRabbit
Documentation
Tests
Style