-
Notifications
You must be signed in to change notification settings - Fork 6
Version 1.14.0 #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.14.0 #511
Conversation
WalkthroughAdds a 1.14.0 release notes block dated 2025-08-26 and bumps project version to 1.14.0 in pyproject.toml. Removes several individual changelog fragment files that were consolidated into the release notes. Notes in the release cover: an Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying infrahub-sdk-python with
|
| Latest commit: |
8d3309f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56179ec1.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-version-1-14-0.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## stable #511 +/- ##
=======================================
Coverage 75.74% 75.74%
=======================================
Files 100 100
Lines 8846 8846
Branches 1732 1732
=======================================
Hits 6700 6700
Misses 1670 1670
Partials 476 476
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
14-26: Polish release notes wording; fix small grammar nits.Capitalize the second Added bullet and fix a duplicated word in a Fixed bullet.
- - add support for NumberPool attributes in generated protocols + - Add support for NumberPool attributes in generated protocols @@ - - Create a new batch while fetching relationships instead of using the reusing the same one. + - Create a new batch while fetching relationships instead of reusing the same one.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
CHANGELOG.md(1 hunks)changelog/+add_numberpool_support_protocols.added.md(0 hunks)changelog/+batch.fixed.md(0 hunks)changelog/+branch-in-count.fixed.md(0 hunks)changelog/466.added.md(0 hunks)changelog/6882.fixed.md(0 hunks)pyproject.toml(1 hunks)
💤 Files with no reviewable changes (5)
- changelog/6882.fixed.md
- changelog/+batch.fixed.md
- changelog/+branch-in-count.fixed.md
- changelog/466.added.md
- changelog/+add_numberpool_support_protocols.added.md
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[grammar] ~24-~24: There might be a mistake here.
Context: ...stead of using the reusing the same one. - Update internal calls to count to incl...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: unit-tests (3.12)
- GitHub Check: unit-tests (3.13)
- GitHub Check: integration-tests-latest-infrahub
🔇 Additional comments (2)
pyproject.toml (1)
3-3: All consistency checks passed; version bump to 1.14.0 is correctly applied
- pyproject.toml’s
version = "1.14.0"is present and correct.- No other hard-coded “1.14.0” strings found outside CHANGELOG/build artifacts.
- No stray
__version__assignments detected.- No release-fragment files remain in changelog/ (all expected files are absent).
No further action needed.
CHANGELOG.md (1)
14-26: Please normalize CHANGELOG style and ensure issue references if available
- I scanned the repository and commit messages for issue/PR numbers related to the “Create a new batch while fetching relationships” and “Update internal calls to
countto include the branch parameter” fixes, but didn’t find any existing references. If there are corresponding issues or pull requests, please add their numbers for traceability.- Otherwise, it’s fine to leave them unreferenced.
Optional style nits:
- Use consistent sentence casing for all bullet points.
- Add or remove trailing periods so they’re uniform across entries.
abfc1aa to
8d3309f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
CHANGELOG.md (2)
18-19: Consistency: capitalize and punctuate the second “Added” bullet.Match the tense/capitalization used elsewhere in the file.
- add support for NumberPool attributes in generated protocols +- Added support for NumberPool attributes in generated protocols.
24-26: Grammar/style fixes in “Fixed” section.
- Remove duplicated “using the reusing”.
- Wrap function name in backticks.
- Prefer “rare cases”.
-- Create a new batch while fetching relationships instead of using the reusing the same one. +- Create a new batch while fetching relationships instead of reusing the same one. - Update internal calls to `count` to include the branch parameter so that the query is performed on the correct branch -- Update offset in process_page() which was causing a race condition in rare case. ([#514](https://github.com/opsmill/infrahub-sdk-python/pull/514)) +- Update offset in `process_page()` which was causing a race condition in rare cases. ([#514](https://github.com/opsmill/infrahub-sdk-python/pull/514))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
CHANGELOG.md(1 hunks)changelog/+add_numberpool_support_protocols.added.md(0 hunks)changelog/+batch.fixed.md(0 hunks)changelog/+branch-in-count.fixed.md(0 hunks)changelog/466.added.md(0 hunks)changelog/6882.fixed.md(0 hunks)pyproject.toml(1 hunks)
💤 Files with no reviewable changes (5)
- changelog/466.added.md
- changelog/6882.fixed.md
- changelog/+add_numberpool_support_protocols.added.md
- changelog/+branch-in-count.fixed.md
- changelog/+batch.fixed.md
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[grammar] ~24-~24: There might be a mistake here.
Context: ...stead of using the reusing the same one. - Update internal calls to count to incl...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: unit-tests (3.13)
- GitHub Check: unit-tests (3.12)
- GitHub Check: integration-tests-latest-infrahub
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
CHANGELOG.md (2)
14-14: Release header/date look good; ensure the tag exists on release.The link points to /tree/v1.14.0 with date 2025-08-26. Please make sure the v1.14.0 tag is created as part of the release process so this link resolves after merge.
14-27: Overall: Release notes are clear and scoped; minor wording/link nits only.Nice consolidation from towncrier fragments and clear Added/Fixed breakdown. Once the small nits above are addressed, this section reads well.
|
|
||
| ### Fixed | ||
|
|
||
| - Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([#6882](https://github.com/opsmill/infrahub-sdk-python/issues/6882)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken/incorrect issue link repository for #6882.
This likely refers to an issue in the main Infrahub repo rather than the SDK repo. The current link points to infrahub-sdk-python/issues/6882 which probably doesn’t exist.
-- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([#6882](https://github.com/opsmill/infrahub-sdk-python/issues/6882))
+- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([opsmill/infrahub#6882](https://github.com/opsmill/infrahub/issues/6882))📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([#6882](https://github.com/opsmill/infrahub-sdk-python/issues/6882)) | |
| - Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([opsmill/infrahub#6882](https://github.com/opsmill/infrahub/issues/6882)) |
🤖 Prompt for AI Agents
In CHANGELOG.md around line 23, the issue link currently points to the SDK repo
(infrahub-sdk-python/issues/6882) but should reference the main Infrahub
repository; replace the incorrect URL with the correct main repo issue link (for
example https://github.com/infrahub/infrahub/issues/6882) or verify the proper
target repo/issue number and update the markdown link accordingly so it points
to the correct issue.
Summary by CodeRabbit