Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Aug 26, 2025

Summary by CodeRabbit

  • New Features
    • infrahubctl now includes a repository init command.
    • Generated protocols support NumberPool attributes.
  • Bug Fixes
    • Fixed flat-notation value lookup in one-to-one relationships.
    • Use a fresh batch when fetching relationships to avoid reuse issues.
    • Count queries now respect the selected branch; offset race condition resolved.
  • Chores
    • Bumped package version to 1.14.0.

@coderabbitai
Copy link

coderabbitai bot commented Aug 26, 2025

Walkthrough

Adds a 1.14.0 release notes block dated 2025-08-26 and bumps project version to 1.14.0 in pyproject.toml. Removes several individual changelog fragment files that were consolidated into the release notes. Notes in the release cover: an infrahubctl repository init command, NumberPool attribute support in generated protocols, fixes for flat-notation value lookup, relationship batching behavior, branch-aware count calls, and an offset race condition. No changes to exported/public API signatures.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pog-version-1.14.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 26, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d3309f
Status: ✅  Deploy successful!
Preview URL: https://56179ec1.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-version-1-14-0.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #511   +/-   ##
=======================================
  Coverage   75.74%   75.74%           
=======================================
  Files         100      100           
  Lines        8846     8846           
  Branches     1732     1732           
=======================================
  Hits         6700     6700           
  Misses       1670     1670           
  Partials      476      476           
Flag Coverage Δ
integration-tests 34.67% <ø> (ø)
python-3.10 48.21% <ø> (ø)
python-3.11 48.19% <ø> (-0.03%) ⬇️
python-3.12 48.19% <ø> (+0.02%) ⬆️
python-3.13 48.19% <ø> (ø)
python-3.9 46.88% <ø> (ø)
python-filler-3.12 25.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

14-26: Polish release notes wording; fix small grammar nits.

Capitalize the second Added bullet and fix a duplicated word in a Fixed bullet.

- - add support for NumberPool attributes in generated protocols
+ - Add support for NumberPool attributes in generated protocols
@@
- - Create a new batch while fetching relationships instead of using the reusing the same one.
+ - Create a new batch while fetching relationships instead of reusing the same one.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1359a2d and abfc1aa.

📒 Files selected for processing (7)
  • CHANGELOG.md (1 hunks)
  • changelog/+add_numberpool_support_protocols.added.md (0 hunks)
  • changelog/+batch.fixed.md (0 hunks)
  • changelog/+branch-in-count.fixed.md (0 hunks)
  • changelog/466.added.md (0 hunks)
  • changelog/6882.fixed.md (0 hunks)
  • pyproject.toml (1 hunks)
💤 Files with no reviewable changes (5)
  • changelog/6882.fixed.md
  • changelog/+batch.fixed.md
  • changelog/+branch-in-count.fixed.md
  • changelog/466.added.md
  • changelog/+add_numberpool_support_protocols.added.md
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[grammar] ~24-~24: There might be a mistake here.
Context: ...stead of using the reusing the same one. - Update internal calls to count to incl...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: unit-tests (3.12)
  • GitHub Check: unit-tests (3.13)
  • GitHub Check: integration-tests-latest-infrahub
🔇 Additional comments (2)
pyproject.toml (1)

3-3: All consistency checks passed; version bump to 1.14.0 is correctly applied

  • pyproject.toml’s version = "1.14.0" is present and correct.
  • No other hard-coded “1.14.0” strings found outside CHANGELOG/build artifacts.
  • No stray __version__ assignments detected.
  • No release-fragment files remain in changelog/ (all expected files are absent).

No further action needed.

CHANGELOG.md (1)

14-26: Please normalize CHANGELOG style and ensure issue references if available

  • I scanned the repository and commit messages for issue/PR numbers related to the “Create a new batch while fetching relationships” and “Update internal calls to count to include the branch parameter” fixes, but didn’t find any existing references. If there are corresponding issues or pull requests, please add their numbers for traceability.
  • Otherwise, it’s fine to leave them unreferenced.

Optional style nits:

  • Use consistent sentence casing for all bullet points.
  • Add or remove trailing periods so they’re uniform across entries.

@ogenstad ogenstad requested a review from a team August 26, 2025 07:17
@ogenstad ogenstad force-pushed the pog-version-1.14.0 branch from abfc1aa to 8d3309f Compare August 26, 2025 17:16
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
CHANGELOG.md (2)

18-19: Consistency: capitalize and punctuate the second “Added” bullet.

Match the tense/capitalization used elsewhere in the file.

 - add support for NumberPool attributes in generated protocols
+- Added support for NumberPool attributes in generated protocols.

24-26: Grammar/style fixes in “Fixed” section.

  • Remove duplicated “using the reusing”.
  • Wrap function name in backticks.
  • Prefer “rare cases”.
-- Create a new batch while fetching relationships instead of using the reusing the same one.
+- Create a new batch while fetching relationships instead of reusing the same one.
 
 - Update internal calls to `count` to include the branch parameter so that the query is performed on the correct branch
-- Update offset in process_page() which was causing a race condition in rare case. ([#514](https://github.com/opsmill/infrahub-sdk-python/pull/514))
+- Update offset in `process_page()` which was causing a race condition in rare cases. ([#514](https://github.com/opsmill/infrahub-sdk-python/pull/514))
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between abfc1aa and 8d3309f.

📒 Files selected for processing (7)
  • CHANGELOG.md (1 hunks)
  • changelog/+add_numberpool_support_protocols.added.md (0 hunks)
  • changelog/+batch.fixed.md (0 hunks)
  • changelog/+branch-in-count.fixed.md (0 hunks)
  • changelog/466.added.md (0 hunks)
  • changelog/6882.fixed.md (0 hunks)
  • pyproject.toml (1 hunks)
💤 Files with no reviewable changes (5)
  • changelog/466.added.md
  • changelog/6882.fixed.md
  • changelog/+add_numberpool_support_protocols.added.md
  • changelog/+branch-in-count.fixed.md
  • changelog/+batch.fixed.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[grammar] ~24-~24: There might be a mistake here.
Context: ...stead of using the reusing the same one. - Update internal calls to count to incl...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: unit-tests (3.13)
  • GitHub Check: unit-tests (3.12)
  • GitHub Check: integration-tests-latest-infrahub
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
CHANGELOG.md (2)

14-14: Release header/date look good; ensure the tag exists on release.

The link points to /tree/v1.14.0 with date 2025-08-26. Please make sure the v1.14.0 tag is created as part of the release process so this link resolves after merge.


14-27: Overall: Release notes are clear and scoped; minor wording/link nits only.

Nice consolidation from towncrier fragments and clear Added/Fixed breakdown. Once the small nits above are addressed, this section reads well.


### Fixed

- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([#6882](https://github.com/opsmill/infrahub-sdk-python/issues/6882))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Broken/incorrect issue link repository for #6882.

This likely refers to an issue in the main Infrahub repo rather than the SDK repo. The current link points to infrahub-sdk-python/issues/6882 which probably doesn’t exist.

-- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([#6882](https://github.com/opsmill/infrahub-sdk-python/issues/6882))
+- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([opsmill/infrahub#6882](https://github.com/opsmill/infrahub/issues/6882))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([#6882](https://github.com/opsmill/infrahub-sdk-python/issues/6882))
- Fix value lookup using a flat notation like `foo__bar__value` with relationships of cardinality one ([opsmill/infrahub#6882](https://github.com/opsmill/infrahub/issues/6882))
🤖 Prompt for AI Agents
In CHANGELOG.md around line 23, the issue link currently points to the SDK repo
(infrahub-sdk-python/issues/6882) but should reference the main Infrahub
repository; replace the incorrect URL with the correct main repo issue link (for
example https://github.com/infrahub/infrahub/issues/6882) or verify the proper
target repo/issue number and update the markdown link accordingly so it points
to the correct issue.

@ogenstad ogenstad merged commit 4f7725b into stable Aug 27, 2025
21 checks passed
@ogenstad ogenstad deleted the pog-version-1.14.0 branch August 27, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants