Skip to content

Fixes race conditions offset #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2025
Merged

Fixes race conditions offset #514

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2da52e
fix some issue with the offset
BeArchiTek Aug 26, 2025
0aee514
add changelog
BeArchiTek Aug 26, 2025
527c0a5
found it !
BeArchiTek Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/+race-condition.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update offset in process_page() which was causing a race condition in rare case.
4 changes: 2 additions & 2 deletions infrahub_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ async def filters(
async def process_page(page_offset: int, page_number: int) -> tuple[dict, ProcessRelationsNode]:
"""Process a single page of results."""
query_data = await InfrahubNode(client=self, schema=schema, branch=branch).generate_query_data(
offset=offset or page_offset,
offset=page_offset if offset is None else offset,
limit=limit or pagination_size,
filters=filters,
include=include,
Expand Down Expand Up @@ -1954,7 +1954,7 @@ def filters(
def process_page(page_offset: int, page_number: int) -> tuple[dict, ProcessRelationsNodeSync]:
"""Process a single page of results."""
query_data = InfrahubNodeSync(client=self, schema=schema, branch=branch).generate_query_data(
offset=offset or page_offset,
offset=page_offset if offset is None else offset,
limit=limit or pagination_size,
filters=filters,
include=include,
Expand Down